Bug 159594

Summary:

Move breaking iterator code to WTF

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, dino, jonlee, simon.fraser, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

159598

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Myles C. Maxfield

Reported 2016-07-08 19:05:52 PDT

Move breaking iterator code to WTF

Attachments
Patch (270.48 KB, patch) 2016-07-08 19:08 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (390.06 KB, patch) 2016-07-08 19:17 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (430.76 KB, patch) 2016-07-08 19:22 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (410.77 KB, patch) 2016-07-09 00:28 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (351.78 KB, patch) 2016-07-09 00:50 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (353.78 KB, patch) 2016-07-09 01:20 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (355.65 KB, patch) 2016-07-09 01:55 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2016-07-08 19:08:51 PDT

Created attachment 283238 [details] Patch

Myles C. Maxfield

Comment 2 2016-07-08 19:17:34 PDT

Created attachment 283239 [details] Patch

WebKit Commit Bot

Comment 3 2016-07-08 19:19:27 PDT

Attachment 283239 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/utext.h:17: #ifndef header guard has wrong style, please use: utext_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/utext.h:138: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/utext.h:143: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/utext.h:182: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:225: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:225: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:243: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:243: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:260: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:260: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:276: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:276: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:292: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:292: The parameter name "rep" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:307: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:307: The parameter name "ci" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:406: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:422: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:450: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:464: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:486: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:507: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:529: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:549: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:564: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:590: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:609: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:634: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:673: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:672: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:675: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:705: Missing spaces around < [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:721: Missing spaces around < [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:737: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:769: Missing spaces around >= [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:769: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:771: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:772: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:804: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:816: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:848: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:849: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:847: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:850: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:888: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:889: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:890: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:887: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:891: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:916: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:930: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:937: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:944: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:950: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:958: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:958: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:1011: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1039: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1070: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1071: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1069: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1072: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1104: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1138: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1158: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1176: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1197: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1224: Extra space between int32_t and tableSize [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1231: Extra space between int32_t and reserved1 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1305: Extra space between UTextClose and *close [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1311: Extra space between UTextClose and *spare1 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1317: Extra space between UTextClose and *spare2 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1323: Extra space between UTextClose and *spare3 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1356: Extra space between uint32_t and magic [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1364: Extra space between int32_t and flags [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1372: Extra space between int32_t and providerProperties [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1380: Extra space between int32_t and sizeOfStruct [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1390: Extra space between int64_t and chunkNativeLimit [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1396: Extra space between int32_t and extraSize [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1405: Extra space between int32_t and nativeIndexingLimit [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1413: Extra space between int64_t and chunkNativeStart [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1420: Extra space between int32_t and chunkOffset [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1426: Extra space between int32_t and chunkLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1450: Extra space between void and *pExtra [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1486: Extra space between void and *privP [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1497: Extra space between int64_t and a [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1504: Extra space between int32_t and b [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1511: Extra space between int32_t and c [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1521: Extra space between int64_t and privA [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1527: Extra space between int32_t and privB [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1533: Extra space between int32_t and privC [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1554: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1563: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:1575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1576: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1577: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1579: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1580: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1582: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1583: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1584: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1585: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1585: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1586: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1586: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1587: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1587: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1588: Use nullptr instead of NULL. [reada bility/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1588: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1589: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1589: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1590: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1590: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1591: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1593: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 128 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 4 2016-07-08 19:22:05 PDT

Created attachment 283241 [details] Patch

WebKit Commit Bot

Comment 5 2016-07-08 19:25:17 PDT

Attachment 283241 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/ubrk.h:8: #ifndef header guard has wrong style, please use: ubrk_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ubrk.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ubrk.h:89: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:91: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:93: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:108: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:215: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:216: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:217: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:214: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:218: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:237: Extra space between int32_t and rulesLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:239: Extra space between int32_t and textLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: Extra space between UParseError and *parseErr [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: The parameter name "parseErr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:241: Extra space between UErrorCode and *status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:263: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:264: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:263: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:285: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:316: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:317: Extra space between int32_t and textLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:317: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:315: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:318: Extra space between UErrorCode* and status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:340: Extra space between UText* and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:340: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:339: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:340: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:341: Extra space between UErrorCode* and status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:354: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:366: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:378: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:389: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:401: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:413: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:414: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:426: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:427: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:462: Extra space between U_STABLE and UBool [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:463: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:474: Extra space between U_STABLE and int32_t [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:475: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:494: Extra space between U_STABLE and int32_t [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:495: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:507: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:507: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:536: Extra space between UText and *text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:536: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:535: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:536: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:537: Extra space between UErrorCode and *status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:17: #ifndef header guard has wrong style, please use: utext_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/utext.h:138: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/utext.h:143: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/utext.h:182: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:225: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:225: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:243: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:243: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:260: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:260: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:276: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:276: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:292: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:292: The parameter name "rep" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:307: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:307: The parameter name "ci" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:406: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:422: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:450: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:464: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:486: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:507: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:529: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:549: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:564: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:590: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:609: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:634: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:673: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:672: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:675: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:705: Missing spaces around < [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:721: Missing spaces around < [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:737: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:769: Missing spaces around >= [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:769: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:771: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:772: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:804: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:816: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:848: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:849: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:847: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:850: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:888: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:889: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:890: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:887: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:891: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:916: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:930: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enum s. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:937: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:944: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:950: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:958: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:958: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:1011: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1039: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1070: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1071: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1069: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1072: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1104: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1138: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1158: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1176: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1197: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1224: Extra space between int32_t and tableSize [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1231: Extra space between int32_t and reserved1 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1305: Extra space between UTextClose and *close [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1311: Extra space between UTextClose and *spare1 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1317: Extra space between UTextClose and *spare2 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1323: Extra space between UTextClose and *spare3 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1356: Extra space between uint32_t and magic [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1364: Extra space between int32_t and flags [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1372: Extra space between int32_t and providerProperties [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1380: Extra space between int32_t and sizeOfStruct [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1390: Extra space between int64_t and chunkNativeLimit [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1396: Extra space between int32_t and extraSize [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1405: Extra space between int32_t and nativeIndexingLimit [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1413: Extra space between int64_t and chunkNativeStart [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1420: Extra space between int32_t and chunkOffset [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1426: Extra space between int32_t and chunkLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1450: Extra space between void and *pExtra [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1486: Extra space between void and *privP [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1497: Extra space between int64_t and a [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1504: Extra space between int32_t and b [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1511: Extra space between int32_t and c [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1521: Extra space between int64_t and privA [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1527: Extra space between int32_t and privB [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1533: Extra space between int32_t and privC [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1554: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1563: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:1575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1576: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1577: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1579: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1580: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1582: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1583: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1584: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1585: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1585: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1586: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1586: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1587: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1587: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1588: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1588: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1589: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1589: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1590: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1590: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1591: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1593: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 193 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 6 2016-07-09 00:28:24 PDT

Created attachment 283249 [details] Patch

WebKit Commit Bot

Comment 7 2016-07-09 00:31:27 PDT

Attachment 283249 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/ubrk.h:8: #ifndef header guard has wrong style, please use: ubrk_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ubrk.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ubrk.h:89: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:91: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:93: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:108: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:215: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:216: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:217: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:214: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:218: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:237: Extra space between int32_t and rulesLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:239: Extra space between int32_t and textLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: Extra space between UParseError and *parseErr [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: The parameter name "parseErr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:241: Extra space between UErrorCode and *status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:263: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:264: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:263: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:285: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:316: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:317: Extra space between int32_t and textLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:317: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:315: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:318: Extra space between UErrorCode* and status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:340: Extra space between UText* and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:340: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:339: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:340: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:341: Extra space between UErrorCode* and status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:354: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:366: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:378: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:389: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:401: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:413: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:414: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:426: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:427: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:462: Extra space between U_STABLE and UBool [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:463: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:474: Extra space between U_STABLE and int32_t [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:475: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:494: Extra space between U_STABLE and int32_t [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:495: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:507: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:507: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:536: Extra space between UText and *text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:536: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:535: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:536: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:537: Extra space between UErrorCode and *status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:17: #ifndef header guard has wrong style, please use: utext_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/utext.h:138: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/utext.h:143: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/utext.h:182: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:225: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:225: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:243: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:243: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:260: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:260: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:276: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:276: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:292: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:292: The parameter name "rep" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:307: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:307: The parameter name "ci" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:406: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:422: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:450: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:464: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:486: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:507: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:529: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:549: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:564: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:590: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:609: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:634: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:673: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:672: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:675: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:705: Missing spaces around < [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:721: Missing spaces around < [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:737: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:769: Missing spaces around >= [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:769: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:771: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:772: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:804: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:816: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:848: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:849: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:847: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:850: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:888: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:889: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:890: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:887: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:891: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:916: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:930: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enum s. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:937: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:944: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:950: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:958: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:958: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:1011: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1039: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1070: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1071: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1069: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1072: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1104: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1138: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1158: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1176: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1197: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1224: Extra space between int32_t and tableSize [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1231: Extra space between int32_t and reserved1 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1305: Extra space between UTextClose and *close [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1311: Extra space between UTextClose and *spare1 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1317: Extra space between UTextClose and *spare2 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1323: Extra space between UTextClose and *spare3 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1356: Extra space between uint32_t and magic [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1364: Extra space between int32_t and flags [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1372: Extra space between int32_t and providerProperties [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1380: Extra space between int32_t and sizeOfStruct [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1390: Extra space between int64_t and chunkNativeLimit [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1396: Extra space between int32_t and extraSize [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1405: Extra space between int32_t and nativeIndexingLimit [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1413: Extra space between int64_t and chunkNativeStart [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1420: Extra space between int32_t and chunkOffset [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1426: Extra space between int32_t and chunkLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1450: Extra space between void and *pExtra [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1486: Extra space between void and *privP [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1497: Extra space between int64_t and a [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1504: Extra space between int32_t and b [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1511: Extra space between int32_t and c [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1521: Extra space between int64_t and privA [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1527: Extra space between int32_t and privB [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1533: Extra space between int32_t and privC [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1554: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1563: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:1575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1576: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1577: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1579: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1580: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1582: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1583: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1584: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1585: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1585: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1586: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1586: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1587: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1587: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1588: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1588: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1589: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1589: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1590: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1590: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1591: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1593: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 193 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 8 2016-07-09 00:50:38 PDT

Created attachment 283250 [details] Patch

WebKit Commit Bot

Comment 9 2016-07-09 00:52:54 PDT

Attachment 283250 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/ubrk.h:8: #ifndef header guard has wrong style, please use: ubrk_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ubrk.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ubrk.h:89: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:91: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:93: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:108: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:215: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:216: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:217: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:214: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:218: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:237: Extra space between int32_t and rulesLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:239: Extra space between int32_t and textLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: Extra space between UParseError and *parseErr [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: The parameter name "parseErr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:241: Extra space between UErrorCode and *status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:263: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:264: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:263: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:285: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:316: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:317: Extra space between int32_t and textLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:317: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:315: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:318: Extra space between UErrorCode* and status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:340: Extra space between UText* and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:340: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:339: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:340: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:341: Extra space between UErrorCode* and status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:354: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:366: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:378: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:389: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:401: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:413: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:414: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:426: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:427: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:462: Extra space between U_STABLE and UBool [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:463: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:474: Extra space between U_STABLE and int32_t [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:475: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:494: Extra space between U_STABLE and int32_t [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:495: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:507: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:507: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:536: Extra space between UText and *text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:536: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:535: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:536: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:537: Extra space between UErrorCode and *status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:17: #ifndef header guard has wrong style, please use: utext_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/utext.h:138: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/utext.h:143: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/utext.h:182: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:225: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:225: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:243: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:243: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:260: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:260: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:276: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:276: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:292: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:292: The parameter name "rep" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:307: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:307: The parameter name "ci" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:406: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:422: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:450: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:464: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:486: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:507: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:529: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:549: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:564: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:590: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:609: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:634: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:673: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:672: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:675: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:705: Missing spaces around < [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:721: Missing spaces around < [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:737: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:769: Missing spaces around >= [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:769: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:771: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:772: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:804: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:816: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:848: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:849: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:847: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:850: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:888: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:889: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:890: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:887: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:891: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:916: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:930: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enum s. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:937: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:944: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:950: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:958: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:958: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:1011: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1039: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1070: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1071: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1069: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1072: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1104: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1138: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1158: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1176: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1197: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1224: Extra space between int32_t and tableSize [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1231: Extra space between int32_t and reserved1 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1305: Extra space between UTextClose and *close [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1311: Extra space between UTextClose and *spare1 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1317: Extra space between UTextClose and *spare2 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1323: Extra space between UTextClose and *spare3 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1356: Extra space between uint32_t and magic [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1364: Extra space between int32_t and flags [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1372: Extra space between int32_t and providerProperties [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1380: Extra space between int32_t and sizeOfStruct [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1390: Extra space between int64_t and chunkNativeLimit [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1396: Extra space between int32_t and extraSize [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1405: Extra space between int32_t and nativeIndexingLimit [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1413: Extra space between int64_t and chunkNativeStart [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1420: Extra space between int32_t and chunkOffset [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1426: Extra space between int32_t and chunkLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1450: Extra space between void and *pExtra [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1486: Extra space between void and *privP [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1497: Extra space between int64_t and a [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1504: Extra space between int32_t and b [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1511: Extra space between int32_t and c [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1521: Extra space between int64_t and privA [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1527: Extra space between int32_t and privB [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1533: Extra space between int32_t and privC [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1554: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1563: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:1575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1576: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1577: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1579: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1580: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1582: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1583: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1584: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1585: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1585: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1586: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1586: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1587: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1587: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1588: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1588: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1589: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1589: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1590: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1590: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1591: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1593: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 193 in 50 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 10 2016-07-09 01:20:56 PDT

Created attachment 283251 [details] Patch

WebKit Commit Bot

Comment 11 2016-07-09 01:22:27 PDT

Attachment 283251 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/ubrk.h:8: #ifndef header guard has wrong style, please use: ubrk_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ubrk.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ubrk.h:89: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:91: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:93: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:108: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:215: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:216: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:217: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:214: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:218: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:237: Extra space between int32_t and rulesLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:239: Extra space between int32_t and textLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: Extra space between UParseError and *parseErr [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: The parameter name "parseErr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:241: Extra space between UErrorCode and *status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:263: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:264: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:263: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:285: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:316: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:317: Extra space between int32_t and textLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:317: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:315: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:318: Extra space between UErrorCode* and status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:340: Extra space between UText* and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:340: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:339: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:340: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:341: Extra space between UErrorCode* and status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:354: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:366: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:378: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:389: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:401: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:413: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:414: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:426: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:427: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:462: Extra space between U_STABLE and UBool [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:463: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:474: Extra space between U_STABLE and int32_t [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:475: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:494: Extra space between U_STABLE and int32_t [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:495: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:507: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:507: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:536: Extra space between UText and *text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:536: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:535: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:536: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:537: Extra space between UErrorCode and *status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:17: #ifndef header guard has wrong style, please use: utext_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/utext.h:138: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/utext.h:143: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/utext.h:182: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:225: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:225: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:243: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:243: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:260: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:260: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:276: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:276: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:292: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:292: The parameter name "rep" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:307: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:307: The parameter name "ci" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:406: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:422: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:450: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:464: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:486: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:507: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:529: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:549: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:564: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:590: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:609: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:634: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:673: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:672: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:675: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:705: Missing spaces around < [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:721: Missing spaces around < [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:737: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:769: Missing spaces around >= [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:769: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:771: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:772: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:804: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:816: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:848: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:849: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:847: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:850: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:888: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:889: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:890: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:887: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:891: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:916: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:930: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enum s. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:937: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:944: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:950: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:958: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:958: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:1011: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1039: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1070: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1071: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1069: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1072: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1104: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1138: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1158: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1176: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1197: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1224: Extra space between int32_t and tableSize [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1231: Extra space between int32_t and reserved1 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1305: Extra space between UTextClose and *close [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1311: Extra space between UTextClose and *spare1 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1317: Extra space between UTextClose and *spare2 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1323: Extra space between UTextClose and *spare3 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1356: Extra space between uint32_t and magic [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1364: Extra space between int32_t and flags [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1372: Extra space between int32_t and providerProperties [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1380: Extra space between int32_t and sizeOfStruct [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1390: Extra space between int64_t and chunkNativeLimit [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1396: Extra space between int32_t and extraSize [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1405: Extra space between int32_t and nativeIndexingLimit [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1413: Extra space between int64_t and chunkNativeStart [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1420: Extra space between int32_t and chunkOffset [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1426: Extra space between int32_t and chunkLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1450: Extra space between void and *pExtra [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1486: Extra space between void and *privP [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1497: Extra space between int64_t and a [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1504: Extra space between int32_t and b [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1511: Extra space between int32_t and c [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1521: Extra space between int64_t and privA [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1527: Extra space between int32_t and privB [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1533: Extra space between int32_t and privC [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1554: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1563: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:1575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1576: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1577: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1579: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1580: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1582: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1583: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1584: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1585: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1585: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1586: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1586: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1587: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1587: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1588: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1588: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1589: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1589: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1590: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1590: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1591: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1593: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 193 in 50 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 12 2016-07-09 01:55:56 PDT

Created attachment 283252 [details] Patch

WebKit Commit Bot

Comment 13 2016-07-09 02:00:02 PDT

Attachment 283252 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/ubrk.h:8: #ifndef header guard has wrong style, please use: ubrk_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ubrk.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ubrk.h:89: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:91: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:93: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:108: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:215: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:216: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:217: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:214: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:218: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:237: Extra space between int32_t and rulesLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:239: Extra space between int32_t and textLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: Extra space between UParseError and *parseErr [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:240: The parameter name "parseErr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:241: Extra space between UErrorCode and *status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:263: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:264: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:263: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:285: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:316: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:317: Extra space between int32_t and textLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:317: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:315: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:318: Extra space between UErrorCode* and status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:318: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:340: Extra space between UText* and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:340: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:339: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:340: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:341: Extra space between UErrorCode* and status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:354: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:366: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:378: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:389: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:401: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:413: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:414: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:426: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:427: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:462: Extra space between U_STABLE and UBool [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:463: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:474: Extra space between U_STABLE and int32_t [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:475: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:494: Extra space between U_STABLE and int32_t [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:495: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:507: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:507: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:536: Extra space between UText and *text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:536: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:535: The parameter name "bi" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:536: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/ubrk.h:537: Extra space between UErrorCode and *status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/ubrk.h:537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:17: #ifndef header guard has wrong style, please use: utext_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/utext.h:138: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/utext.h:143: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/utext.h:182: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:225: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:225: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:243: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:243: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:260: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:260: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:276: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:276: The parameter name "s" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:292: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:292: The parameter name "rep" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:307: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:307: The parameter name "ci" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:406: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:422: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:450: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:464: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:486: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:507: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:529: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:549: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:564: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:590: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:609: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:634: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:673: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:674: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:672: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:675: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:705: Missing spaces around < [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:721: Missing spaces around < [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:736: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:737: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:769: Missing spaces around >= [whitespace/operators] [3] ERROR: Source/WTF/icu/unicode/utext.h:769: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:771: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:772: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:804: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:816: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:848: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:849: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:847: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:850: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:888: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:889: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:890: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:887: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:891: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:916: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:930: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enum s. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:937: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:944: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:950: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:958: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:958: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:1011: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1039: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1070: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1071: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1069: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1072: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1104: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1138: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1158: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1176: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1197: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1224: Extra space between int32_t and tableSize [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1231: Extra space between int32_t and reserved1 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1305: Extra space between UTextClose and *close [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1311: Extra space between UTextClose and *spare1 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1317: Extra space between UTextClose and *spare2 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1323: Extra space between UTextClose and *spare3 [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1356: Extra space between uint32_t and magic [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1364: Extra space between int32_t and flags [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1372: Extra space between int32_t and providerProperties [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1380: Extra space between int32_t and sizeOfStruct [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1390: Extra space between int64_t and chunkNativeLimit [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1396: Extra space between int32_t and extraSize [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1405: Extra space between int32_t and nativeIndexingLimit [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1413: Extra space between int64_t and chunkNativeStart [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1420: Extra space between int32_t and chunkOffset [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1426: Extra space between int32_t and chunkLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1450: Extra space between void and *pExtra [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1486: Extra space between void and *privP [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1497: Extra space between int64_t and a [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1504: Extra space between int32_t and b [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1511: Extra space between int32_t and c [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1521: Extra space between int64_t and privA [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1527: Extra space between int32_t and privB [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1533: Extra space between int32_t and privC [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/utext.h:1554: The parameter name "ut" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/utext.h:1563: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/utext.h:1575: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1576: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1577: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1579: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1580: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1582: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1583: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1584: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1585: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1585: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1586: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1586: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1587: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1587: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1588: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1588: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1589: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1589: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1590: Use nullptr instead of NULL. [readability/null] [5] ERROR: Source/WTF/icu/unicode/utext.h:1590: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1591: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/utext.h:1593: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 193 in 53 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 14 2016-07-09 23:40:11 PDT

Comment on attachment 283252 [details] Patch Move things. r=me. I don't see the error in the windows ews. Watch the bots after you land and fix any breakage.

WebKit Commit Bot

Comment 15 2016-07-10 10:15:49 PDT

Comment on attachment 283252 [details] Patch Clearing flags on attachment: 283252 Committed r203038: <http://trac.webkit.org/changeset/203038>

WebKit Commit Bot

Comment 16 2016-07-10 10:15:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.