Bug 159587

Summary: Cleanup: Remove use of PassRefPtr from class HTMLTableElement
Product: WebKit Reporter: Daniel Bates <dbates>
Component: TablesAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, esprehn+autocc, gyuyoung.kim
Priority: P2    
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Daniel Bates
Reported 2016-07-08 16:45:57 PDT
Towards removing class PassRefPtr we should remove use of it from class HTMLTableElement. Currently HTMLTableElement::set{Caption, THead}() take a PassRefPtr argument. We should modify these functions to take a rvalue reference to a RefPtr.
Attachments
Patch (4.42 KB, patch)
2016-07-08 16:48 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (4.49 KB, patch)
2016-07-08 17:23 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-07-08 16:48:26 PDT
Created attachment 283224 [details] Patch
Chris Dumez
Comment 2 2016-07-08 16:51:08 PDT
Comment on attachment 283224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283224&action=review > Source/WebCore/html/HTMLTableElement.cpp:147 > return head; You're returning head after moving it :S > Source/WebCore/html/HTMLTableElement.cpp:185 > return caption; ditto.
Daniel Bates
Comment 3 2016-07-08 17:07:11 PDT
(In reply to comment #2) > > Source/WebCore/html/HTMLTableElement.cpp:147 > > return head; > > You're returning head after moving it :S > I'm blind.
Daniel Bates
Comment 4 2016-07-08 17:23:45 PDT
Created attachment 283230 [details] Patch
Chris Dumez
Comment 5 2016-07-08 18:24:14 PDT
Comment on attachment 283230 [details] Patch r=me
Daniel Bates
Comment 6 2016-07-08 19:15:23 PDT
Comment on attachment 283230 [details] Patch Clearing flags on attachment: 283230 Committed r203016: <http://trac.webkit.org/changeset/203016>
Daniel Bates
Comment 7 2016-07-08 19:15:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.