Bug 159582

Summary: bundle-v3-scripts.py should compress HTML/CSS templates
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, joepeck, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch joepeck: review+

Ryosuke Niwa
Reported 2016-07-08 14:40:03 PDT
Since v3 UI embeds HTML and CSS inside the scripts, we should be stripping whitespace in bundle-v3-scripts.py from those.
Attachments
Patch (3.33 KB, patch)
2016-07-08 16:59 PDT, Ryosuke Niwa 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-07-08 16:59:06 PDT
Created attachment 283225 [details] Patch
Joseph Pecoraro
Comment 2 2016-07-08 20:26:35 PDT
Comment on attachment 283225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283225&action=review r=me! > Websites/perf.webkit.org/tools/bundle-v3-scripts.py:51 > + content = re.sub(r'\s+([{};:])', r'\1', content) This could have a bug with ":" for the new things like "foo :matches(...)" would suddenly change. You could copy the cssminify function that the inspector uses and use it here: (1 of these) Source/JavaScriptCore/Scripts/cssmin.py Source/WebInspectorUI/Scripts/cssmin.py
Ryosuke Niwa
Comment 3 2016-07-08 20:32:39 PDT
Committed r203019: <http://trac.webkit.org/changeset/203019>
Note You need to log in before you can comment on or make changes to this bug.