| Summary: | base64 spends 1.1% of total time checking for special Infinity case | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
| Component: | JavaScriptCore | Assignee: | Geoffrey Garen <ggaren> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, ggaren | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.4 | ||||||
| Attachments: |
|
||||||
I'll take this. Created attachment 17221 [details]
Patch
Comment on attachment 17221 [details]
Patch
Looking reasonable. r=me.
Comment on attachment 17221 [details]
Patch
Oh. I figured we'd had up kjs_dota, but this looks great too. :)
Committed revision 27748. |
base64 spends 1.1% of total time working around toDouble/kjs_dota logic mismatch Well, here's another softball: at least 1.4% of *total time* in base64 is spent on this line in UString::toDouble: if (strncmp(c, "Infinity", 8) == 0) { We already have our own custom dota (aka kjs_dota) we just need a way to call into that logic where it doesn't ever return "Infinity" and instead does what UString::toDouble wants it to.