Bug 159563

Summary: AX: Eliminate test noise from roles-computedRoleString.html
Product: WebKit Reporter: Joanmarie Diggs <jdiggs>
Component: AccessibilityAssignee: Joanmarie Diggs <jdiggs>
Status: RESOLVED FIXED    
Severity: Trivial CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Joanmarie Diggs
Reported 2016-07-08 09:31:17 PDT
The expectations for roles-computedRoleString.html include a " X" at the top. This " X" is noise, and unintentional noise at that. (We try to hide all the content; we're just missing some.) And its presence can trigger false positives such as what is seen in bug 139403. At some point we can consider always hiding the content (when it is unrelated to what is being tested) for all of our tests. In the meantime, I see no good reason why the "fix" for the issue in bug 139403 should be to update the noise.
Attachments
Patch (3.89 KB, patch)
2016-07-08 09:34 PDT, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-07-08 09:31:47 PDT
<rdar://problem/27247069>
Joanmarie Diggs
Comment 2 2016-07-08 09:34:16 PDT
Created attachment 283171 [details] Patch
WebKit Commit Bot
Comment 3 2016-07-08 11:02:34 PDT
Comment on attachment 283171 [details] Patch Clearing flags on attachment: 283171 Committed r202994: <http://trac.webkit.org/changeset/202994>
WebKit Commit Bot
Comment 4 2016-07-08 11:02:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.