Bug 159553

Summary: [GStreamer] remove WEBKIT_DEBUG support
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch calvaris: review+

Philippe Normand
Reported 2016-07-08 04:07:27 PDT
The calls to LOG_VERBOSE produce garbage on ARM, at least: ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp(1555) : virtual void WebCore::MediaPlayerPrivateGStreamer::updateStates() maxTimeLoaded: 415938299809481995712198243795165442114446608251198541412533532200303259382674825171887552015390677062453343278568941921082741130768288101511873905211177299203022876703061554139618503974386816465718904469000118736930747555634551649061902668527822349806206623533610353420531539424404447103291289916932096.000000 ../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp(1416) : virtual float WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded() const didLoadingProgress: 2126735596 Also this is confusing in general. In a debug build one can simply enable WEBKIT_DEBUG=Media and/or GST_DEBUG=webkit* if GStreamer logs are needed.
Attachments
patch (41.69 KB, patch)
2016-07-08 05:52 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
patch (41.70 KB, patch)
2016-07-08 05:55 PDT, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2016-07-08 05:52:19 PDT
Created attachment 283140 [details] patch
Philippe Normand
Comment 2 2016-07-08 05:55:14 PDT
Created attachment 283142 [details] patch
Xabier Rodríguez Calvar
Comment 3 2016-07-11 06:28:06 PDT
Comment on attachment 283142 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=283142&action=review It's a pity that we can't use the _OBJECT counterparts as these are not GObjects. > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:53 > + GST_DEBUG("Destroying"); We might want to use GST_TRACE here as TRACE is used to track references, etc. Not a strong opinion, change it or land it as it is.
Philippe Normand
Comment 4 2016-07-11 07:42:40 PDT
Committed r203058: <http://trac.webkit.org/changeset/203058>
Note You need to log in before you can comment on or make changes to this bug.