Bug 159551

Summary:

REGRESSION(r202273): [GTK] Redirected X window is resized to the previous size on size allocate

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, bugs-noreply, commit-queue, gustavo, mcatanzaro, mrobinson, zan

Priority:

Keywords:

Gtk, Regression

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mcatanzaro: review+

Description Carlos Garcia Campos 2016-07-08 03:52:44 PDT

In r202273 I added webkitWebViewBaseResizeRedirectedWindow() helper to remove duplicated code in all places where we were resizing the redirected window to the current drawing area size. But on size allocate, we were updating the redirected window first, and then the drawing area, to ensure that when the drawing area notifies the web process the redirected window is already at the new size. This regression doesn't have any visual effect, because we are ensure the right size always before rendering, but there's a small extra resize in this case.

Comment 1 Carlos Garcia Campos 2016-07-08 03:54:21 PDT

Created attachment 283133 [details]
Patch

Comment 2 WebKit Commit Bot 2016-07-08 03:55:55 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Carlos Garcia Campos 2016-07-13 23:35:03 PDT

Committed r203215: <http://trac.webkit.org/changeset/203215>