Bug 159510 – [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Per Arne Vollan]

We need to allow any https certificate in DumpRenderTree.

[Per Arne Vollan]

Created attachment 283019 [details]
Patch

[Brent Fulgham]

Comment on attachment 283019 [details]
Patch

r=me

[Per Arne Vollan]

(In reply to comment #2)
> Comment on attachment 283019 [details]
> Patch
> 
> r=me

Thanks for reviewing!

[Per Arne Vollan]

Committed r202967: <https://trac.webkit.org/changeset/202967>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 159556

[Per Arne Vollan]

Created attachment 316979 [details]
Patch

[Daniel Bates]

Comment on attachment 316979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316979&action=review

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:1214
> +    request->setAllowsAnyHTTPSCertificate();

OK. Although it is unlikely that DumpRenderTree would be used to load an arbitrary URL (and would be an error if run-webkit-test ever invoked with a non-file, non-localhost URL) it would be good practice to take a similar approach as in Mac DumpRenderTree/WebKitTestRunner and only allow any HTTPS certificate for localhost and 127.0.0.1.

[Per Arne Vollan]

(In reply to Daniel Bates from comment #7)
> Comment on attachment 316979 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316979&action=review
> 
> > Tools/DumpRenderTree/win/DumpRenderTree.cpp:1214
> > +    request->setAllowsAnyHTTPSCertificate();
> 
> OK. Although it is unlikely that DumpRenderTree would be used to load an
> arbitrary URL (and would be an error if run-webkit-test ever invoked with a
> non-file, non-localhost URL) it would be good practice to take a similar
> approach as in Mac DumpRenderTree/WebKitTestRunner and only allow any HTTPS
> certificate for localhost and 127.0.0.1.

Thanks for reviewing! I will add a host check in a follow-up patch.

[WebKit Commit Bot]

Comment on attachment 316979 [details]
Patch

Clearing flags on attachment: 316979

Committed r220206: <http://trac.webkit.org/changeset/220206>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33700981>