Summary: | Return values of JSArray::createUninitialized (and related) are not consistently checked for nullptr | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | WebCore Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan, mkwst, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=160014 | ||||||||
Attachments: |
|
Description
Brent Fulgham
2016-07-06 15:53:52 PDT
Created attachment 282964 [details]
Patch
Comment on attachment 282964 [details]
Patch
Why are we logging these failures instead of throwing a JS exception?
Comment on attachment 282964 [details]
Patch
Why didn't we see a log in the test output?
(In reply to comment #4) > Comment on attachment 282964 [details] > Patch > > Why didn't we see a log in the test output? It shows up in the stderr, so if the test fails you actually can see the logging output. I don't know how to get WTFLogAlways stuff into test output. (In reply to comment #3) > Comment on attachment 282964 [details] > Patch > > Why are we logging these failures instead of throwing a JS exception? I don't think we throw JS exceptions from deep inside platform code (or at least a quick search didn't find anything helpful). I definitely CAN do so in CanvasRenderingContext2D::getImageData, which makes the test much clearer. Created attachment 282969 [details]
Patch
Comment on attachment 282969 [details] Patch Clearing flags on attachment: 282969 Committed r202887: <http://trac.webkit.org/changeset/202887> All reviewed patches have been landed. Closing bug. |