Bug 159484

Summary:

Multiple Picture Sources Downloading e.g. webp and jpeg

Product:

WebKit

Reporter:

Lee <lee+bugzilla>

Component:

Images

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Major

CC:

achristensen, colin, hyatt, jonlee, maximuse.chern, mjs, simon.fraser, tetsuharu.ohzeki, webkit, webkit-bug-importer, yoav

Priority:

Keywords:

InRadar

Version:

Safari 9

Hardware:

Mac

OS:

OS X 10.11

See Also:

https://bugs.webkit.org/show_bug.cgi?id=245411

Attachments:

Description	Flags
Example html file and screenshot, as on gist.github.com.	none
Example using external javascript	none

Lee

Reported 2016-07-06 12:19:56 PDT

Created attachment 282923 [details] Example html file and screenshot, as on gist.github.com. I think I've found an odd bug in Safari related to the picture element and downloading multiple sources, which I've been advised may be a Webkit thing. See example html: https://gist.github.com/notlee/73ebe50c3af907f3cde875afd9cd61c1 Actual: For the picture element seen in the example above, both the webp source and jpeg img fallback downloads unless (oddly) you delete the script tag, remove the new line between the opening and closing of the script tag, or delete the link tag href contents. ¯\_(ツ)_/¯ Expected: The expected behaviour being to only download one picture source or the img element fallback. In this case ignore the webp picture source, given Safari doesn't support it, and therefore only download the jpeg img. Observed on: OSX 10.11.5 Safari Version 9.1.1 (11601.6.17) Safari Preview Version 9.1.2 (11601.7.4, 11602.1.37)

Attachments
Example html file and screenshot, as on gist.github.com. (34.07 KB, application/zip) 2016-07-06 12:19 PDT, Lee	no flags	Details
Example using external javascript (35.07 KB, application/zip) 2017-09-19 02:45 PDT, Anders	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-07-12 09:33:35 PDT

<rdar://problem/27301646>

Anders

Comment 2 2017-09-19 02:45:55 PDT

Created attachment 321191 [details] Example using external javascript Just to confirm that this still appears to the an open issue. The example HTML from Lee worked fine for me, but a slightly modified one has the same issue. It looks like any external script BEFORE the picture tag causes the issue. Moving the script tag to after the picture tag seems to solve it. Observed on: OS X 10.12.6 Safari Version 10.1.2 (12603.3.8) Safari Technology Preview 39 (Safari 11.1, Webkit 12605.1.4.0.1) Webkit Nightly 222202 - with cache disabled (works if the external file is cached)

Colin Bendell

Comment 3 2017-11-16 12:11:58 PST

I believe this is a duplicate of bug 179231

Maciej Stachowiak

Comment 4 2020-07-09 04:23:09 PDT

This case isn't exactly identical, in that there are not multiple <source> elements, but it does seem similar, and may have been fixed by that change.

Said Abou-Hallawa

Comment 5 2020-09-01 09:25:18 PDT

*** Bug 177068 has been marked as a duplicate of this bug. ***

Said Abou-Hallawa

Comment 6 2020-09-01 09:27:42 PDT

*** Bug 215805 has been marked as a duplicate of this bug. ***

Yoav Weiss

Comment 7 2024-07-22 03:24:56 PDT

https://github.com/WebKit/WebKit/pull/31055 addresses this

Note You need to log in before you can comment on or make changes to this bug.