Bug 159477

Summary: [iOS] Text suggestions should be cleared when form input session is invalidated
Product: WebKit Reporter: Chelsea Pugh <cpugh>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, cpugh, mitz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[iOS] Text suggestions should be cleared when form input session is invalidated.txt
none
Patch v2 none

Description Chelsea Pugh 2016-07-06 11:16:05 PDT 
Text suggestions should be cleared when form input session is invalidated. Patch forthcoming.
Comment 1 Chelsea Pugh 2016-07-06 11:21:02 PDT 
Created attachment 282913 [details]
[iOS] Text suggestions should be cleared when form input session is invalidated.txt
Comment 2 Chelsea Pugh 2016-07-06 16:07:06 PDT 
Created attachment 282957 [details]
Patch v2

New patch where we just set the input delegate's suggestions to nil rather than nil-ing out the suggestions that the client set.
Comment 3 mitz 2016-07-06 16:09:34 PDT 
Comment on attachment 282957 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=282957&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:373
> +    [suggestionDelegate setSuggestions:nil];

Can’t write suggestionDelegate.suggestions = nil?
Comment 4 WebKit Commit Bot 2016-07-06 16:38:35 PDT 
Comment on attachment 282957 [details]
Patch v2

Clearing flags on attachment: 282957

Committed r202884: <http://trac.webkit.org/changeset/202884>
Comment 5 WebKit Commit Bot 2016-07-06 16:38:39 PDT 
All reviewed patches have been landed.  Closing bug.