Bug 159459 – Expose crossOrigin attribute as a static property in HTMLMediaElement

• Component: Media
• Status: RESOLVED FIXED

[Olivier Blin]

The crossOrigin attribute is already used for MediaResourceLoader (r119742 and r175050), but it was not exposed as a static property.

Exposing it fixes VR360 support in Dailymotion, since it uses the "in" operator to detect if crossOrigin is supported by the HTMLVideoElement, in order to enable VR360.

[Olivier Blin]

Example VR360 video that failed to play in VR360 mode:
http://www.dailymotion.com/embed/video/x4jiicp?autoplay=1

[Olivier Blin]

Created attachment 282865 [details]
Patch

[Olivier Blin]

If the approach is correct, should I write a test for this?

[WebKit Commit Bot]

Attachment 282865 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:15:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 282865 [details]
Patch

Attachment 282865 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1634779

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html

[Build Bot]

Created attachment 282869 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282865 [details]
Patch

Attachment 282865 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1634826

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html

[Build Bot]

Created attachment 282872 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 282865 [details]
Patch

Attachment 282865 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1634834

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html

[Build Bot]

Created attachment 282873 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Chris Dumez]

(In reply to comment #7)
> Comment on attachment 282865 [details]
> Patch
> 
> Attachment 282865 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.webkit.org/results/1634826
> 
> New failing tests:
> imported/w3c/web-platform-tests/html/dom/interfaces.html
> imported/w3c/web-platform-tests/html/dom/reflection-embedded.html

Chances are that these tests cover your change. Please rebaseline them in your patch.

[Olivier Blin]

(In reply to comment #11)
> (In reply to comment #7)
> > Comment on attachment 282865 [details]
> > Patch
> > 
> > Attachment 282865 [details] did not pass mac-ews (mac):
> > Output: http://webkit-queues.webkit.org/results/1634826
> > 
> > New failing tests:
> > imported/w3c/web-platform-tests/html/dom/interfaces.html
> > imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
> 
> Chances are that these tests cover your change. Please rebaseline them in
> your patch.

Will do.

Besides that, are you ok with the change?
Should I write a test?

Thanks

[Chris Dumez]

Comment on attachment 282865 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282865&action=review

The change looks good.

> Source/WebCore/ChangeLog:15
> +        No new tests (OOPS!).

Also, please update this line to something like:
No new tests, rebaselined existing tests.

> Source/WebCore/html/HTMLMediaElement.h:170
> +    String crossOrigin() const;

It would probably be nice to update HTMLMediaElement::mediaPlayerCreateResourceLoader() to use the new crossOrigin() getter as well.

[Olivier Blin]

Created attachment 283160 [details]
Patch

Rebaselined for 150 WPT tests that are now fixed, and updated mediaPlayerCreateResourceLoader() to use the new getter

[Chris Dumez]

Comment on attachment 283160 [details]
Patch

r=me

[Build Bot]

Comment on attachment 283160 [details]
Patch

Attachment 283160 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1647236

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html

[Build Bot]

Created attachment 283165 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Chris Dumez]

(In reply to comment #17)
> Created attachment 283165 [details]
> Archive of layout-test-results from ews123 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

You need to overwrite LayoutTests//platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt with the reflection-embedded-actual.txt that you will find in:
https://bugs.webkit.org/attachment.cgi?id=283165

[Chris Dumez]

Committed r202980: <http://trac.webkit.org/changeset/202980>

[Chris Dumez]

(In reply to comment #18)
> (In reply to comment #17)
> > Created attachment 283165 [details]
> > Archive of layout-test-results from ews123 for ios-simulator-wk2
> > 
> > The attached test failures were seen while running run-webkit-tests on the
> > ios-sim-ews.
> > Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5
> 
> You need to overwrite
> LayoutTests//platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/
> reflection-embedded-expected.txt with the reflection-embedded-actual.txt
> that you will find in:
> https://bugs.webkit.org/attachment.cgi?id=283165

Don't worry about it, I fixed it and landed the patch.

[Alexey Proskuryakov]

*** Bug 103257 has been marked as a duplicate of this bug. ***