Bug 159437

Summary: Facebook videos without audio tracks will sometimes cause playback controls to appear.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=159533
Bug Depends on:    
Bug Blocks: 159496    
Attachments:
Description Flags
Patch eric.carlson: review+

Jer Noble
Reported 2016-07-05 15:26:02 PDT
Facebook videos without audio tracks will sometimes cause playback controls to appear.
Attachments
Patch (4.82 KB, patch)
2016-07-05 15:44 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-07-05 15:44:58 PDT
Created attachment 282818 [details] Patch
Jer Noble
Comment 2 2016-07-05 15:46:27 PDT
<rdar://problem/27114174>
Eric Carlson
Comment 3 2016-07-06 08:24:10 PDT
Comment on attachment 282818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282818&action=review > Source/WebCore/html/HTMLMediaElement.cpp:7119 > + if (!m_updatePlaybackControlsManagerQueue.hasPendingTasks()) > + m_updatePlaybackControlsManagerQueue.enqueueTask(std::bind(&HTMLMediaElement::updatePlaybackControlsManager, this)); Why do we need yet another GenericTaskQueue member variable, couldn't you give m_pauseAfterDetachedTaskQueue a more generic name (e.g. m_deferredTaskQueue?) and use it? If not, don't you need to call m_updatePlaybackControlsManagerQueue.close() in contextDestroyed and in the destructor?
Jer Noble
Comment 4 2016-07-07 11:01:30 PDT
Committed r202918: <http://trac.webkit.org/changeset/202918>
Note You need to log in before you can comment on or make changes to this bug.