Bug 159426
| Summary: | Clicking bubbles on Build Bot Console page no longer shows popover with links | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, dbates, joepeck, lforschler, ryanhaddad |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Joseph Pecoraro
Summary:
Clicking bubbles on Build Bot Console page no longer shows popover with links.
Steps to Reproduce:
1. Load <https://build.webkit.org/console?category=AppleMac>
2. Click on a Gold / Red bubble
=> Nothing happens
Errors in Console:
[Error] Refused to display 'https://build.webkit.org/buildstatus?builder=Apple%20El%20Capitan%20%28Leaks%29&number=6367' in a frame because it set 'X-Frame-Options' to 'DENY'.
[Error] Sandbox access violation: Blocked a frame at "https://build.webkit.org" from accessing a frame at "null". The frame being accessed is sandboxed and lacks the "allow-same-origin" flag.
onload (console:4655)
[Error] TypeError: undefined is not an object (evaluating 'document.getElementById("frameBox").contentWindow.document.body')
updateDiv (console:45:84)
onload (console:4655)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
This reproduces in shipping Safari/WebKit, and as far as I know, we haven't changed anything about buildbot version or configuration.
Do you remember when this last worked? I never attempted clicking on these before.
$ curl -i 'https://build//build.webkit.org/buildstatus?builder=Apple%20El%20Capitan%20%28Leaks%29&number=6367'
HTTP/1.1 200 OK
Date: Wed, 06 Jul 2016 00:57:56 GMT
Server: TwistedWeb/12.1.0
X-Frame-Options: DENY
...
Alexey Proskuryakov
Looks like current Buildbot version doesn't have this problem: <http://buildbot.buildbot.net/console>
Joseph Pecoraro
(In reply to comment #1)
> This reproduces in shipping Safari/WebKit, and as far as I know, we haven't
> changed anything about buildbot version or configuration.
>
> Do you remember when this last worked? I never attempted clicking on these
> before.
I think a month ago (early June) it was working.
Alexey Proskuryakov
Jon Davis just fixed this by changing X-Frame-Options to SAMEORIGIN.