Bug 159418

Summary:

Replace multiscripts-positions.html reftest with script tests

Product:

WebKit

Reporter:

Frédéric Wang Nélar <fred.wang>

Component:

MathML

Assignee:

Frédéric Wang Nélar <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, alex, bfulgham, buildbot, commit-queue, dbarton, mrobinson, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	mrobinson: review+

Frédéric Wang Nélar

Reported 2016-07-05 07:05:39 PDT

The test multiscripts-positions.html is not really reliable because it does not use any OpenType MATH fonts. It is marked "Pass ImageOnlyFailure" on mac and ios: find -type f -name TestExpectations | xargs grep multiscripts Layout/platform/ios-simulator/TestExpectations:mathml/presentation/multiscripts-positions.html [ Pass ImageOnlyFailure ] Layout/platform/mac/TestExpectations:mathml/presentation/multiscripts-positions.html [ Pass ImageOnlyFailure ] The following script tests allow some error tolerance and should be better to test the default behavior without knowing which specific font is used: http://tests.mathml-association.org/mathml/presentation-markup/scripts/subsup-2.html http://tests.mathml-association.org/mathml/presentation-markup/scripts/subsup-3.html

Attachments
Patch (32.83 KB, patch) 2016-07-05 07:14 PDT, Frédéric Wang Nélar	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.01 MB, application/zip) 2016-07-05 07:50 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-yosemite (782.84 KB, application/zip) 2016-07-05 08:01 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (643.84 KB, application/zip) 2016-07-05 08:11 PDT, Build Bot	no flags	Details
Patch (32.83 KB, patch) 2016-07-05 08:18 PDT, Frédéric Wang Nélar	mrobinson: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Frédéric Wang Nélar

Comment 1 2016-07-05 07:14:38 PDT

Created attachment 282783 [details] Patch

Build Bot

Comment 2 2016-07-05 07:50:40 PDT

Comment on attachment 282783 [details] Patch Attachment 282783 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1630163 New failing tests: imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-3.html

Build Bot

Comment 3 2016-07-05 07:50:45 PDT

Created attachment 282785 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-07-05 08:01:45 PDT

Comment on attachment 282783 [details] Patch Attachment 282783 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1630203 New failing tests: imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-3.html

Build Bot

Comment 5 2016-07-05 08:01:49 PDT

Created attachment 282787 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-07-05 08:11:25 PDT

Comment on attachment 282783 [details] Patch Attachment 282783 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1630208 New failing tests: imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-3.html

Build Bot

Comment 7 2016-07-05 08:11:29 PDT

Created attachment 282792 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4

Frédéric Wang Nélar

Comment 8 2016-07-05 08:18:57 PDT

Created attachment 282793 [details] Patch

Martin Robinson

Comment 9 2016-07-07 07:06:47 PDT

Comment on attachment 282793 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282793&action=review > LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-2.html:16 > + /* This test does not use any specific fonts and so the exacts rules are not nit: exacts rules => exact rules

Frédéric Wang Nélar

Comment 10 2016-07-07 07:26:52 PDT

Committed r202906: <http://trac.webkit.org/changeset/202906>

Note You need to log in before you can comment on or make changes to this bug.