Bug 15941 – sunspider-compare-results should not depend on tmp/sunspider-test-prefix.js

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

sunspider-compare-results should not depend on tmp/sunspider-test-prefix.js

If you try to compare two results files, after having run run-sunspider-results with a different set of tests than the original results files, you'll get this error:

Checking Dependencies...
** BUILD SUCCEEDED **
Starting sunspider-compare-results with DYLD_FRAMEWORK_PATH set to point to built JavaScriptCore in /Stuff/Users/eric/Projects/build/Release.
[18986] resources/sunspider-standalone-compare.js line 151: TypeError: Undefined value


Commonly I gen my results files, then gen a shark file (for one test) and then try to look back at my original results, and I have to re-run run-sunspider before I'm able to actually compare again...

[Olivier DOLE]

Created attachment 27878 [details]
store sunspider results in a specific directory instead of tmp

I have exactly the same problem. If I run V8 test suite then sunspider and re-run V8, sunspider-compare-results will not be able to generate a correct report.
So I did a patch to fix this behavior. sunspider script will store results in:
- sunspider-results directory for sunspider tests
- ubench-results for ubench tests
- v8-results directory for V8 test suite
I have also added an option to sunspider-compare-results to tell it which kind of test suite results to compare.

[Eric Seidel (no email)]

I haven't run sunspider in a long time, so I'm not the best reviewer here.  Maciej or Geoff are better choices.

[Eric Seidel (no email)]

Comment on attachment 27878 [details]
store sunspider results in a specific directory instead of tmp

Given that this has not been reviewed in 2 months, I don't suspect it will be any time soon.  Marking r-.  If you'd like to change this code, I suggest contacting othermaciej or ggaren or weinig or olliej in #webkit and pestering them.  Or you could email any of the above directly.

[Maciej Stachowiak]

Comment on attachment 27878 [details]
store sunspider results in a specific directory instead of tmp

Reflagging for review. No reason was given to reject this patch.

[Maciej Stachowiak]

Comment on attachment 27878 [details]
store sunspider results in a specific directory instead of tmp

Looks good.

[Brent Fulgham]

Landed in @r44168.