| Summary: | [JSC] Object.getOwnPropertyDescriptors should not add undefined props to result | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Caitlin Potter (:caitp) <caitp> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, darin, keith_miller, ljharb, mark.lam, msaboff, saam, ysuzuki | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Caitlin Potter (:caitp)
2016-07-04 09:58:35 PDT
Created attachment 282727 [details]
Patch
Created attachment 282729 [details]
Patch
Hi, We're landing this change in V8 today, believing it (https://github.com/tc39/ecma262/pull/593) is likely to reach consensus at the next TC39 meeting. It probably wouldn't hurt to land this in WebKit as well, but it's fine to wait until the spec change is decided on. In any case, if consensus isn't reached, it's simple enough to simply revert the patch. This patch also fixes up these tests and moves them to a more appropriate directory. Let's wait until the spec change is decided. This received consensus at the July 2016 TC39 meeting; please merge at your leisure. Thanks Jordan, I'll make sure this isn't bitrotten today before signing off. (In reply to comment #6) > Thanks Jordan, I'll make sure this isn't bitrotten today before signing off. Sounds good. I'll review when you say this patch is OK or if you post a rebased version. Created attachment 284648 [details]
Patch
(In reply to comment #7) > (In reply to comment #6) > > Thanks Jordan, I'll make sure this isn't bitrotten today before signing off. > > Sounds good. I'll review when you say this patch is OK or if you post a > rebased version. I've posted a rebased version Comment on attachment 284648 [details]
Patch
r=me
Comment on attachment 284648 [details] Patch Clearing flags on attachment: 284648 Committed r203747: <http://trac.webkit.org/changeset/203747> All reviewed patches have been landed. Closing bug. Thanks everybody! |