Summary: | WebProcesses don't handle DatabaseProcess going away uncleanly. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, alecflett, ap, commit-queue, jsbell, sam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=155506 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 149117 | ||||||||
Attachments: |
|
Description
Brady Eidson
2016-07-01 14:08:51 PDT
Created attachment 282610 [details]
Patch
This patch is a WIP - The source changes are likely good, the test isn't complete. Just attaching so I can have easy access at home later. Created attachment 282659 [details]
Patch
Comment on attachment 282659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282659&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:96 > + // Allow file URLs to load non-file resources > + [configuration _setAllowUniversalAccessFromFileURLs:YES]; This comment doesn't seem necessary. > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:121 > + EXPECT_EQ(receivedAtLeastOneOpenError, true); EXPECT_TRUE Comment on attachment 282659 [details] Patch Clearing flags on attachment: 282659 Committed r202809: <http://trac.webkit.org/changeset/202809> All reviewed patches have been landed. Closing bug. Will make those test tweaks in a follow up |