Summary: | [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||
Component: | Tools / Tests | Assignee: | Per Arne Vollan <pvollan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, lforschler | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Per Arne Vollan
2016-07-01 04:12:52 PDT
Created attachment 282536 [details]
Patch
Created attachment 282698 [details]
Patch
Comment on attachment 282698 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282698&action=review > Source/WebCore/ChangeLog:9 > + Implement a way to find the core Frame from the document list. Did you try using the "core(WebFrame*)" function? I think this would do what you want, and be consistent with how the macOS version of this works. > Source/WebCore/testing/js/WebCoreTestSupport.h:54 > +void setTestCallbackAndStartNotificationTimer(JSContextRef, JSObjectRef) TEST_SUPPORT_EXPORT; You might not need this... > Tools/DumpRenderTree/win/EventSender.cpp:827 > + WebCoreTestSupport::setTestCallbackAndStartNotificationTimer(globalContext, jsCallbackFunction); Could you pass the WebCore::Frame backing the IWebFrame object to the existing WebCoreTestSupport::setTestCallbackAndStartNotificationTimer? See the "core(WebFrame*)" method in WebFrame.h. (In reply to comment #3) > Comment on attachment 282698 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282698&action=review > > > Source/WebCore/ChangeLog:9 > > + Implement a way to find the core Frame from the document list. > > Did you try using the "core(WebFrame*)" function? I think this would do what > you want, and be consistent with how the macOS version of this works. > > > Source/WebCore/testing/js/WebCoreTestSupport.h:54 > > +void setTestCallbackAndStartNotificationTimer(JSContextRef, JSObjectRef) TEST_SUPPORT_EXPORT; > > You might not need this... > > > Tools/DumpRenderTree/win/EventSender.cpp:827 > > + WebCoreTestSupport::setTestCallbackAndStartNotificationTimer(globalContext, jsCallbackFunction); > > Could you pass the WebCore::Frame backing the IWebFrame object to the > existing WebCoreTestSupport::setTestCallbackAndStartNotificationTimer? > > See the "core(WebFrame*)" method in WebFrame.h. I would like to use this, although wouldn't this mean crossing some boundary, since WebFrame and WebCore::Frame are not part of the COM api? Thanks for reviewing! Created attachment 283907 [details]
Patch
Thanks for reviewing! Committed r203403: <http://trac.webkit.org/changeset/203403> |