Bug 159316 – Web Inspector: Shift-Tab should unindent selected line

• Component: Web Inspector
• Status: RESOLVED FIXED

[Nikita Vasilyev]

Shift-Tab unindent selected line in:

— Chrome DevTools
— Firefox DevTools
— Sublime Text
— WebStorm

It also unindents bullet point list items in macOS apps like Mail and Notes.

It doesn't do anything in Xcode.


Steps:
1. Inspect this page.
2. Open global.css on this page.
3. Select first line
4. Press Tab
5. Press Shift-Tab

Expected:
Pressing Shift-Tab undone indentation level created by pressing Tab.

Actual:
Nothing happens.

[Radar WebKit Bug Importer]

<rdar://problem/27115241>

[Devin Rousso]

Created attachment 286807 [details]
Patch

I have tested this in as many CodeMirror instances as I can, and so far I haven't seen any issues (it seems like `readOnly` prevents Shift-Tab as well):
 - Text and Script resources
 - CSS Sidebar
 - Console Prompt
 - Debugger expression popover

[Build Bot]

Comment on attachment 286807 [details]
Patch

Attachment 286807 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1931461

New failing tests:
transitions/default-timing-function.html

[Build Bot]

Created attachment 286824 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Nikita Vasilyev]

Comment on attachment 286807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286807&action=review

Looks good to me.

> Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js:-592
> -        "Shift-Tab": ignoreKey,

I don't know why ignoreKey is here.

`git blame` shows that this was introduced in 2013 when Web Inspector was re-opensourced.
https://trac.webkit.org/changeset/151453
Tim or Joe may remember.

[Joseph Pecoraro]

Comment on attachment 286807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286807&action=review

r=me

>> Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js:-592
>> -        "Shift-Tab": ignoreKey,
> 
> I don't know why ignoreKey is here.
> 
> `git blame` shows that this was introduced in 2013 when Web Inspector was re-opensourced.
> https://trac.webkit.org/changeset/151453
> Tim or Joe may remember.

Probably to override the default "Shift-Tab", which is "indentAuto" and probably not what we want.

[WebKit Commit Bot]

Comment on attachment 286807 [details]
Patch

Clearing flags on attachment: 286807

Committed r204924: <http://trac.webkit.org/changeset/204924>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.