Bug 159291

Summary:

[image-decoders] Use final and override in ImageDecoder subclasses

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	tonikitoo: review+

Description Carlos Garcia Campos 2016-06-30 01:21:32 PDT

ssia.

Comment 1 Carlos Garcia Campos 2016-06-30 01:23:05 PDT

Created attachment 282419 [details]
Patch

Comment 2 WebKit Commit Bot 2016-06-30 01:24:53 PDT

Attachment 282419 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/image-decoders/bmp/BMPImageDecoder.h:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageDecoder.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Carlos Garcia Campos 2016-06-30 06:38:01 PDT

Committed r202677: <http://trac.webkit.org/changeset/202677>