Summary: | [JSC] Date.setYear() misses timeClip() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, joepeck, keith_miller, mark.lam, msaboff, saam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Benjamin Poulain
2016-06-29 18:49:26 PDT
Created attachment 282405 [details]
Patch
Comment on attachment 282405 [details]
Patch
r=me
Comment on attachment 282405 [details] Patch Clearing flags on attachment: 282405 Committed r202683: <http://trac.webkit.org/changeset/202683> All reviewed patches have been landed. Closing bug. Comment on attachment 282405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282405&action=review > LayoutTests/js/date-timeClip-large-values-expected.txt:56 > +FAIL new Date(0).setYear(1.79769e+308).valueOf() should be NaN. Was -62135596800000. > +FAIL new Date(0).setYear(-1.79769e+308).valueOf() should be NaN. Was -62135596800000. These tests FAIL. Is that expected? (In reply to comment #5) > Comment on attachment 282405 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282405&action=review > > > LayoutTests/js/date-timeClip-large-values-expected.txt:56 > > +FAIL new Date(0).setYear(1.79769e+308).valueOf() should be NaN. Was -62135596800000. > > +FAIL new Date(0).setYear(-1.79769e+308).valueOf() should be NaN. Was -62135596800000. > > These tests FAIL. Is that expected? Yep. It's part of a much bigger bug: GregorianDateTime cannot handle big values. |