| Summary: | [iOS] Process suspension is prevented for 30 seconds after closing a tab | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | andersca, barraclough, beidson, commit-queue, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 159284 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Chris Dumez
2016-06-29 15:54:07 PDT
Created attachment 282385 [details]
Patch
Attachment 282385 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:156: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 282392 [details]
Patch
Attachment 282392 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:156: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 282407 [details]
Patch without Gavin's refactoring
Attachment 282407 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:157: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The patch fixes the issue. However, I will need to rebaseline after Gavin lands his refactoring patch in Bug 159284. Created attachment 282409 [details]
Patch with Gavin's refactoring
Attachment 282409 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:158: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 282409 [details] Patch with Gavin's refactoring View in context: https://bugs.webkit.org/attachment.cgi?id=282409&action=review > Source/WebKit2/UIProcess/ProcessAssertion.h:63 > + bool isValid() const { return m_isValid; } Suggestion – make this an enum with three states – one for uninitialized. Currently while uninitialized this enum disagrees with the state of BKSProcessAssertion. > Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:158 > + m_assertion.get().invalidationHandler = ^() { I'm worried about the lifetime of this callback – I think you should reset this in the destructor. Created attachment 282455 [details]
Patch
Attachment 282455 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:158: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 282455 [details] Patch Clearing flags on attachment: 282455 Committed r202696: <http://trac.webkit.org/changeset/202696> All reviewed patches have been landed. Closing bug. |