Bug 159280 – [iOS] Process suspension is prevented for 30 seconds after closing a tab

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Process suspension is prevented for 30 seconds after closing a tab due to ConnectionTerminationWatchdog holding a background assertion.

[Chris Dumez]

<rdar://problem/27014867>

[Chris Dumez]

Created attachment 282385 [details]
Patch

[WebKit Commit Bot]

Attachment 282385 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:156:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 282392 [details]
Patch

[WebKit Commit Bot]

Attachment 282392 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:156:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 282407 [details]
Patch without Gavin's refactoring

[WebKit Commit Bot]

Attachment 282407 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:157:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

The patch fixes the issue. However, I will need to rebaseline after Gavin lands his refactoring patch in Bug 159284.

[Chris Dumez]

Created attachment 282409 [details]
Patch with Gavin's refactoring

[WebKit Commit Bot]

Attachment 282409 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:158:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gavin Barraclough]

Comment on attachment 282409 [details]
Patch with Gavin's refactoring

View in context: https://bugs.webkit.org/attachment.cgi?id=282409&action=review

> Source/WebKit2/UIProcess/ProcessAssertion.h:63
> +    bool isValid() const { return m_isValid; }

Suggestion – make this an enum with three states – one for uninitialized.

Currently while uninitialized this enum disagrees with the state of BKSProcessAssertion.

> Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:158
> +    m_assertion.get().invalidationHandler = ^() {

I'm worried about the lifetime of this callback – I think you should reset this in the destructor.

[Chris Dumez]

Created attachment 282455 [details]
Patch

[WebKit Commit Bot]

Attachment 282455 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:158:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 282455 [details]
Patch

Clearing flags on attachment: 282455

Committed r202696: <http://trac.webkit.org/changeset/202696>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.