Summary: | Add "type" and "paymentPass" properties in PaymentMethod | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2016-06-29 14:52:35 PDT
Created attachment 282377 [details]
Patch
Comment on attachment 282377 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282377&action=review > Source/WebCore/ChangeLog:13 > + * platform/cocoa/ThemeCocoa.mm: > + (WebCore::drawApplePayButton): You didn't explain this change. > Source/WebCore/Modules/applepay/cocoa/PaymentMethodCocoa.mm:55 > + case PKPaymentPassActivationStateActivated: > + return @"activated"; > + > + case PKPaymentPassActivationStateRequiresActivation: > + return @"requiresActivation"; > + > + case PKPaymentPassActivationStateActivating: > + return @"activating"; > + > + case PKPaymentPassActivationStateSuspended: > + return @"suspended"; > + > + case PKPaymentPassActivationStateDeactivated: > + return @"deactivated"; > + > + default: > + return nil; Why all the blank lines? > Source/WebCore/Modules/applepay/cocoa/PaymentMethodCocoa.mm:93 > + switch (paymentMethodType) { > + case PKPaymentMethodTypeDebit: > + return @"debit"; > + > + case PKPaymentMethodTypeCredit: > + return @"credit"; > + > + case PKPaymentMethodTypePrepaid: > + return @"prepaid"; > + > + case PKPaymentMethodTypeStore: > + return @"store"; > + > + case PKPaymentMethodTypeUnknown: > + default: > + return nil; > + } And here? Committed r202655: <http://trac.webkit.org/changeset/202655> |