Bug 159278 – Add "type" and "paymentPass" properties in PaymentMethod

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Add "type" and "paymentPass" properties in PaymentMethod

[Anders Carlsson]

Created attachment 282377 [details]
Patch

[Dean Jackson]

Comment on attachment 282377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282377&action=review

> Source/WebCore/ChangeLog:13
> +        * platform/cocoa/ThemeCocoa.mm:
> +        (WebCore::drawApplePayButton):

You didn't explain this change.

> Source/WebCore/Modules/applepay/cocoa/PaymentMethodCocoa.mm:55
> +    case PKPaymentPassActivationStateActivated:
> +        return @"activated";
> +
> +    case PKPaymentPassActivationStateRequiresActivation:
> +        return @"requiresActivation";
> +
> +    case PKPaymentPassActivationStateActivating:
> +        return @"activating";
> +
> +    case PKPaymentPassActivationStateSuspended:
> +        return @"suspended";
> +
> +    case PKPaymentPassActivationStateDeactivated:
> +        return @"deactivated";
> +
> +    default:
> +        return nil;

Why all the blank lines?

> Source/WebCore/Modules/applepay/cocoa/PaymentMethodCocoa.mm:93
> +    switch (paymentMethodType) {
> +    case PKPaymentMethodTypeDebit:
> +        return @"debit";
> +
> +    case PKPaymentMethodTypeCredit:
> +        return @"credit";
> +
> +    case PKPaymentMethodTypePrepaid:
> +        return @"prepaid";
> +
> +    case PKPaymentMethodTypeStore:
> +        return @"store";
> +
> +    case PKPaymentMethodTypeUnknown:
> +    default:
> +        return nil;
> +    }

And here?

[Anders Carlsson]

Committed r202655: <http://trac.webkit.org/changeset/202655>