Bug 159263 – Pass SecurityOrigin as references in CORS check code

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

Pass SecurityOrigin as references in CORS check code

[youenn fablet]

Created attachment 282346 [details]
Patch

[Alex Christensen]

Comment on attachment 282346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282346&action=review

This is indeed no change in behavior.  If there's no security origin when doing CORS checks, something has gone horribly wrong

> Source/WebCore/loader/DocumentThreadableLoader.cpp:448
> +    ASSERT(m_document.securityOrigin());

Don't we only need this to be true if m_origin is non-null?

[youenn fablet]

Thanks for the review.

> > Source/WebCore/loader/DocumentThreadableLoader.cpp:448
> > +    ASSERT(m_document.securityOrigin());
> 
> Don't we only need this to be true if m_origin is non-null?

Right, strictly speaking, the assertion is too wide.
At the same time, having a non-null origin and a document with a null origin sounds worrying.

[WebKit Commit Bot]

Comment on attachment 282346 [details]
Patch

Clearing flags on attachment: 282346

Committed r202674: <http://trac.webkit.org/changeset/202674>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.