Summary: | [css-grid] Inline size is never indefinite during layout | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||
Component: | Layout and Rendering | Assignee: | Manuel Rego Casasnovas <rego> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, simon.fraser, svillar | ||||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=616716 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 60731 | ||||||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2016-06-29 00:32:03 PDT
Created attachment 282330 [details]
Patch
Comment on attachment 282330 [details]
Patch
There are many more gridTrackSize() calls in the code, are you completely sure that all the other ones are only called during the TrackSizing phase?
Created attachment 282892 [details]
Patch
(In reply to comment #2) > Comment on attachment 282330 [details] > Patch > > There are many more gridTrackSize() calls in the code, are you completely > sure that all the other ones are only called during the TrackSizing phase? Yep you're right, I just make the SizingOperation a mandatory argument for gridTrackSize(). So we're sure we're passing the right one in every call. Otherwise, it was hard to tell if all of them were called during the TrackSizing phase only. Comment on attachment 282892 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=282892&action=review > Source/WebCore/ChangeLog:12 > + This makes Grid Layout compatible with regular blocks regarding Put everything in the same paragraph. > Source/WebCore/rendering/RenderGrid.cpp:763 > + // For the inline axis this only happens when we're computing the intrinsic sizes (AvailableSpaceIndefinite). Better use IntrinsicSizeComputation which is what we're checking bellow. > LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html:122 > + <!-- The height of the row is wrong calculated in the following 2 examples because of a bug in FIXME needed? Created attachment 283131 [details]
Patch for landing
Thanks for the review. Applied suggested changes.
Comment on attachment 283131 [details] Patch for landing Clearing flags on attachment: 283131 Committed r202974: <http://trac.webkit.org/changeset/202974> All reviewed patches have been landed. Closing bug. |