Bug 159246

Summary: ES6SampleBench should have a harness
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2016-06-28 21:44:56 PDT
Patch forthcoming.
Attachments
the patch (33.42 KB, patch)
2016-06-28 21:50 PDT, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-06-28 21:50:25 PDT
Created attachment 282318 [details] the patch
Saam Barati
Comment 2 2016-06-28 22:06:53 PDT
Comment on attachment 282318 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=282318&action=review > PerformanceTests/ES6SampleBench/driver.js:152 > + magicFrame.contentDocument.write( > + "<!DOCTYPE html><head><title>benchmark payload</title></head><body><script>\n" + > + "window.onerror = top." + this._key + ".reportError;\n" + > + "function reportResult()\n" + > + "{\n" + > + " var driver = top." + this._key + ";\n" + > + " driver.reportResult.apply(driver, arguments);\n" + > + "}\n" + > + "</script>\n" + > + this._benchmark.code + "</body></html>"); Nit: This would be easier to read as a template literal
Filip Pizlo
Comment 3 2016-06-28 22:54:54 PDT
(In reply to comment #2) > Comment on attachment 282318 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=282318&action=review > > > PerformanceTests/ES6SampleBench/driver.js:152 > > + magicFrame.contentDocument.write( > > + "<!DOCTYPE html><head><title>benchmark payload</title></head><body><script>\n" + > > + "window.onerror = top." + this._key + ".reportError;\n" + > > + "function reportResult()\n" + > > + "{\n" + > > + " var driver = top." + this._key + ";\n" + > > + " driver.reportResult.apply(driver, arguments);\n" + > > + "}\n" + > > + "</script>\n" + > > + this._benchmark.code + "</body></html>"); > > Nit: This would be easier to read as a template literal Good idea! Fixed.
Filip Pizlo
Comment 4 2016-06-28 22:56:19 PDT
Landed in https://trac.webkit.org/changeset/202613
Note You need to log in before you can comment on or make changes to this bug.