Bug 159209

Summary: [Coordinated Graphics] Move CompositingCoordinator from platform to WebKit2 layer
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, yoon, zan
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 159144    
Bug Blocks: 159212    
Attachments:
Description Flags
Patch
none
Rebased patch
zan: review+, buildbot: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Carlos Garcia Campos
Reported 2016-06-28 03:32:28 PDT
It's a layering violation, that code belongs to the WebKit2 layer.
Attachments
Patch (99.11 KB, patch)
2016-06-28 03:36 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Rebased patch (99.14 KB, patch)
2016-06-29 05:21 PDT, Carlos Garcia Campos 		zan: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (937.24 KB, application/zip)
2016-06-29 06:18 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-06-28 03:36:00 PDT
Created attachment 282238 [details] Patch To make the review easier I haven't changed any code, just moved it, updated the header includes and added some WebCore::. I plan to do further cleanup in a follow up patch.
Carlos Garcia Campos
Comment 2 2016-06-29 05:21:34 PDT
Created attachment 282341 [details] Rebased patch This should apply on trunk now
Build Bot
Comment 3 2016-06-29 06:18:24 PDT
Comment on attachment 282341 [details] Rebased patch Attachment 282341 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1594193 New failing tests: animations/multiple-backgrounds.html
Build Bot
Comment 4 2016-06-29 06:18:27 PDT
Created attachment 282343 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Carlos Garcia Campos
Comment 5 2016-06-29 06:28:34 PDT
(In reply to comment #3) > Comment on attachment 282341 [details] > Rebased patch > > Attachment 282341 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/1594193 > > New failing tests: > animations/multiple-backgrounds.html This is just code moved and shouldn't affect iOS at all.
Carlos Garcia Campos
Comment 6 2016-06-30 00:33:08 PDT
Committed r202675: <http://trac.webkit.org/changeset/202675>
Note You need to log in before you can comment on or make changes to this bug.