Bug 159202

Summary: Rewrite the tests of scripts-subsup.html
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alex, bfulgham, commit-queue, dbarton, mrobinson, rego, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 119002, 142289    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch
none
Patch mrobinson: review+

Frédéric Wang (:fredw)
Reported 2016-06-28 02:25:42 PDT
The test mathml/presentation/scripts-subsup.html is supposed to check the rendering of subsup scripts. However, the MathML 3 recommendation does not specify precisely how to implement these scripted elements so the test is not really accurate / reliable. Currently it is failing on most platforms: LayoutTests$ find -type f -name TestExpectations | xargs grep scripts-subsup.html ./platform/ios-simulator/TestExpectations:mathml/presentation/scripts-subsup.html [ Pass ImageOnlyFailure ] ./platform/gtk/TestExpectations:webkit.org/b/142289 mathml/presentation/scripts-subsup.html [ ImageOnlyFailure ] ./platform/ios-simulator-wk1/TestExpectations:mathml/presentation/scripts-subsup.html [ ImageOnlyFailure ] ./platform/mac/TestExpectations:mathml/presentation/scripts-subsup.html [ Pass ImageOnlyFailure ] Moreover, we are testing several things in one reftest. We should probably split it into smaller tests and try and improve it (e.g. using javascript to measure boxes instead). Most of the features are probably already tested by imported/mathml-in-html5/mathml/subsup-parameters-1.html.
Attachments
Patch (19.68 KB, patch)
2016-07-04 06:18 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (651.33 KB, application/zip)
2016-07-04 07:15 PDT, Build Bot 		no flags
Details
Patch (20.62 KB, patch)
2016-07-04 07:29 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (20.65 KB, patch)
2016-07-05 01:49 PDT, Frédéric Wang (:fredw) 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2016-07-04 06:18:55 PDT
Created attachment 282711 [details] Patch
Build Bot
Comment 2 2016-07-04 07:15:13 PDT
Comment on attachment 282711 [details] Patch Attachment 282711 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1624469 New failing tests: mathml/presentation/scripts-subsup.html
Build Bot
Comment 3 2016-07-04 07:15:16 PDT
Created attachment 282716 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Frédéric Wang (:fredw)
Comment 4 2016-07-04 07:29:52 PDT
Created attachment 282718 [details] Patch
Frédéric Wang (:fredw)
Comment 5 2016-07-05 01:49:07 PDT
Created attachment 282760 [details] Patch
Frédéric Wang (:fredw)
Comment 6 2016-07-07 07:21:04 PDT
Committed r202904: <http://trac.webkit.org/changeset/202904>
Note You need to log in before you can comment on or make changes to this bug.