Bug 159184 – REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app

• Component: New Bugs
• Status: RESOLVED FIXED

[Tim Horton]

REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app

[Tim Horton]

Created attachment 282192 [details]
Patch

[WebKit Commit Bot]

Attachment 282192 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebImmediateActionController.mm:530:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 282192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282192&action=review

Any way to test this?

> Source/WebKit/mac/WebView/WebHTMLView.mm:6369
> +    if (!selectionRange)
> +        return;

OK to continue if the range is empty?

[Tim Horton]

(In reply to comment #3)
> Comment on attachment 282192 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282192&action=review
> 
> Any way to test this?

Even if we had TextIndicator tests, I'm not sure how we could test that this particular caller does the right thing. Maybe we could have a way to get the current indicator and actually call the context menu-y method on WebHTMLView? Anyway, TextIndicator is high on my list of things that desperately needs to be testable but currently isn't (and progress has been made in the past in this direction).

> > Source/WebKit/mac/WebView/WebHTMLView.mm:6369
> > +    if (!selectionRange)
> > +        return;
> 
> OK to continue if the range is empty?

The other function will catch that.

[Tim Horton]

https://trac.webkit.org/changeset/202524