Summary: | B3 should not use Nops when deleting unreachable code | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, saam, sam | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Filip Pizlo
2016-06-25 13:55:52 PDT
Created attachment 282083 [details]
the patch
Attachment 282083 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/b3/testb3.cpp:12064: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:12078: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/b3/B3InsertionSet.h:88: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 3 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 282084 [details]
the patch
Better patch.
Attachment 282084 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/b3/testb3.cpp:12064: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:12078: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 282084 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=282084&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + - replaceWithNop() if the type is Void or if know that we'll fix any users of this value. Change "if know" to "if we know". > Source/JavaScriptCore/b3/B3Value.h:96 > + // method less you kill a value safely. It will replace Void values with Nop and non-Void "less" => "lets" Landed in https://trac.webkit.org/changeset/202502 |