| Summary: | [GTK] Use GtkBindingSet to make key bindings user-configurable | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alp Toker <alp> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Minor | CC: | alp | ||||||||
| Priority: | P2 | Keywords: | Gtk | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alp Toker
2007-11-08 17:07:34 PST
See also bug #15653 One place to look for inspiration on this outside of GTK+ is the gtkhtml widget. They have an emacs editor keybinding there too. Created attachment 17686 [details]
patch key bindings and clipboard
This patch fixes this bug and #16144.
Fixing key bindings fixed also clipboard and other keys for the page.
Take care epiphany issue on these bindings is not related to this.
Comment on attachment 17686 [details]
patch key bindings and clipboard
review +
This patch is looking good, thanks. Works well. I'm just going to do some research to make sure the API changes are supportable before actually reviewing this. Created attachment 17696 [details]
same patch without bold, italic, undo, redo
Hi,
this one does the same thing as the previous one but does not change bold, italic and redo/undo actions behavior.
Those can be left as is however, since they work only in editable regions. That's the job of handleKeypress.
Created attachment 17697 [details]
patch indentation
Comment on attachment 17697 [details]
patch indentation
r=me
Thanks!
Before landing I'll fix some remaining whitespace issues and remove some tabs. Also cleaning up the docs a bit, and changing the order of cut/copy/paste to match convention, but that's just aesthetic.
|