Bug 159108

Summary:

B3 should die sooner if a Value has the wrong number of children

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	mark.lam: review+

Description Filip Pizlo 2016-06-24 16:42:42 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2016-06-24 16:46:05 PDT

Created attachment 282031 [details]
the patch

Comment 2 WebKit Commit Bot 2016-06-24 16:48:08 PDT

Attachment 282031 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3Value.h:373:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3Value.h:379:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3Value.h:385:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3Value.h:391:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/b3/B3Value.h:397:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 5 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Mark Lam 2016-06-24 16:50:36 PDT

Comment on attachment 282031 [details]
the patch

r=me

Comment 4 Filip Pizlo 2016-06-24 17:04:30 PDT

Landed in https://trac.webkit.org/changeset/202463