Summary: | TransactionOperations can get destroyed on the wrong thread | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, alecflett, cdumez, commit-queue, jsbell, ossy | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 154968 | ||||||
Attachments: |
|
Description
Brady Eidson
2016-06-24 15:42:14 PDT
This is a race, pure and simple. The operation completion has to happen on the background thread so quickly that it's done before the main thread that scheduled the background thread task even finishes doing so. It's going to be difficult to write a dedicated test for. But it will clear up random bot exposure in random workers tests. Created attachment 282735 [details]
Patch
Attachment 282735 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/indexeddb/IDBActiveDOMObject.h:66: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The Windows build breakage is not from this patch. Comment on attachment 282735 [details] Patch Clearing flags on attachment: 282735 Committed r202821: <http://trac.webkit.org/changeset/202821> All reviewed patches have been landed. Closing bug. (In reply to comment #5) > Comment on attachment 282735 [details] > Patch > > Clearing flags on attachment: 282735 > > Committed r202821: <http://trac.webkit.org/changeset/202821> (In reply to comment #4) > The Windows build breakage is not from this patch. It's not true, it broke the Apple Windows and WinCairo build too, see build.webkit.org for details. (In reply to comment #7) > (In reply to comment #5) > > Comment on attachment 282735 [details] > > Patch > > > > Clearing flags on attachment: 282735 > > > > Committed r202821: <http://trac.webkit.org/changeset/202821> > > (In reply to comment #4) > > The Windows build breakage is not from this patch. > > It's not true, it broke the Apple Windows and WinCairo build too, > see build.webkit.org for details. Yup, sure did. I saw other errors when I looked at the EWS, but they were apparently just warnings. |