| Summary: | [WK2] PageConfiguration.m_relatedPage keeps WebPageProxy alive after its WebView has been destroyed | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, beidson, benjamin, cmarcelo, commit-queue, sam, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2016-06-23 20:07:24 PDT
Created attachment 281955 [details]
Patch
Attachment 281955 [details] did not pass style-queue:
ERROR: Source/WTF/wtf/WeakPtr.h:95: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 281955 [details]
Patch
I think this would break compatibility - the related web view configuration property is not weak. How about just clearing out the page configuration's related page in ::close() ?
(In reply to comment #4) > Comment on attachment 281955 [details] > Patch > > I think this would break compatibility - the related web view configuration > property is not weak. How about just clearing out the page configuration's > related page in ::close() ? Thanks for the suggestion. I'll give this a try. I think we would keep at most 1 extra WebPageProxy alive instead of a chain of them so this would be a big improvement. Created attachment 281958 [details]
Patch
Comment on attachment 281958 [details] Patch Clearing flags on attachment: 281958 Committed r202426: <http://trac.webkit.org/changeset/202426> All reviewed patches have been landed. Closing bug. |