Summary: | Media elements should not lose playback controls when muted by a user gesture | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jer Noble
2016-06-23 17:56:14 PDT
Created attachment 281949 [details]
Patch
Comment on attachment 281949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281949&action=review > Source/WebCore/html/MediaElementSession.cpp:239 > + } Is it ok to return true even if any of the conditions below in the "if (m_element.isVideo())" block would otherwise return false? Should both these checks happen after that block? Comment on attachment 281949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281949&action=review >> Source/WebCore/html/MediaElementSession.cpp:239 >> + } > > Is it ok to return true even if any of the conditions below in the "if (m_element.isVideo())" block would otherwise return false? Should both these checks happen after that block? We don't want to do the size check if we already have had a user gesture, which is why this was moved before. The only case that changes here is that videos which are not in the DOM but are playing due to a user gesture will now show up in the DFR. So in that sense, it's the same as a playing <audio> element, and I think that's fine. Created attachment 282018 [details]
Patch
Comment on attachment 282018 [details] Patch Clearing flags on attachment: 282018 Committed r202459: <http://trac.webkit.org/changeset/202459> All reviewed patches have been landed. Closing bug. |