Bug 159062

Summary: Handle (0, 0) ranges from Lookup
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton
Priority: P2 Keywords: InRadar
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=159063
Attachments:
Description Flags
proposed patch
none
proposed patch thorton: review+, thorton: commit-queue-

Alexey Proskuryakov
Reported 2016-06-23 11:01:47 PDT
When Lookup can't provide a range, it sometimes returns (NSNotFound, 0), and other times, (0, 0). In the latter case, we somehow build a single character string. rdar://problem/26960385
Attachments
proposed patch (2.82 KB, patch)
2016-06-23 11:08 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (2.75 KB, patch)
2016-06-23 11:09 PDT, Alexey Proskuryakov 		thorton: review+
thorton: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2016-06-23 11:08:28 PDT
Created attachment 281916 [details] proposed patch
Alexey Proskuryakov
Comment 2 2016-06-23 11:09:28 PDT
Created attachment 281917 [details] proposed patch Forgot to update a FIXME.
Tim Horton
Comment 3 2016-06-23 11:11:06 PDT
Comment on attachment 281917 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=281917&action=review > Source/WebCore/editing/mac/DictionaryLookup.mm:144 > + // FIXME (159063): We shouldn't need to check for zero lenght here. lenght!
Alexey Proskuryakov
Comment 4 2016-06-23 12:18:15 PDT
Committed http://trac.webkit.org/r202390
Note You need to log in before you can comment on or make changes to this bug.