Bug 159053

Summary:

CSSComputedStyleDeclaration::length should recalculate styles if needed to provide the correct value

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

CSS

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, hyatt, joepeck, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[TEST] Reduction Test Page	none
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	simon.fraser: review+, simon.fraser: commit-queue-
[PATCH] For Landing	none

Joseph Pecoraro

Reported 2016-06-22 21:46:44 PDT

Created attachment 281896 [details] [TEST] Reduction Test Page Summary: CSSComputedStyleDeclaration::length should recalculate styles if needed to provide the correct value. JavaScript access to the ComputedStyleDeclaration should always have the most accurate data. That should include accessing the length. Right now the length is out of date until a style recalculation or forced layout (such as accessing an item / propertyValue in the computed style). Test: <body> <script> var computedStyle = window.getComputedStyle(document.body); var defaultLength = computedStyle.length; document.documentElement.style.setProperty('--default-color', '#c80'); var newLength = computedStyle.length; document.body.offsetTop; var finalLength = computedStyle.length; console.log("default", defaultLength); console.log("new - with computed property", newLength); console.log("final - after forced layout", finalLength); </script> Results: Expect "new" and "final" to be equal, and both be 1 greater than "default". Safari: (bad) default – 331 new - with computed property – 331 final - after forced layout – 332 Firefox: (expected) default 263 new - with computed property 264 final - after forced layout 264 Chrome: Doesn't appear to include computed properties in Computed Style at all.

Attachments
[TEST] Reduction Test Page (455 bytes, text/html) 2016-06-22 21:46 PDT, Joseph Pecoraro	no flags	Details
[PATCH] Proposed Fix (3.42 KB, patch) 2016-06-22 22:03 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] Proposed Fix (3.41 KB, patch) 2016-06-22 22:05 PDT, Joseph Pecoraro	simon.fraser: review+ simon.fraser: commit-queue-	Details Formatted Diff Diff
[PATCH] For Landing (3.80 KB, patch) 2016-06-23 11:14 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2016-06-22 21:47:03 PDT

<rdar://problem/26638119>

Joseph Pecoraro

Comment 2 2016-06-22 22:03:45 PDT

Created attachment 281897 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 3 2016-06-22 22:04:44 PDT

Comment on attachment 281897 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281897&action=review > LayoutTests/fast/css/variables/custom-property-computed-style-length-update-expected.html:2 > +<head> Err, I should clean up the test...

Joseph Pecoraro

Comment 4 2016-06-22 22:05:28 PDT

Created attachment 281898 [details] [PATCH] Proposed Fix

Simon Fraser (smfr)

Comment 5 2016-06-22 22:53:12 PDT

Comment on attachment 281898 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281898&action=review > LayoutTests/fast/css/variables/custom-property-computed-style-length-update.html:12 > +document.write(success ? "PASS" : "FAIL"); This should be a dumpAsText(). There's no point using a ref test (two snapshots and hashing) for this.

Joseph Pecoraro

Comment 6 2016-06-23 11:14:57 PDT

Created attachment 281918 [details] [PATCH] For Landing

WebKit Commit Bot

Comment 7 2016-06-23 11:43:56 PDT

Comment on attachment 281918 [details] [PATCH] For Landing Clearing flags on attachment: 281918 Committed r202382: <http://trac.webkit.org/changeset/202382>

Note You need to log in before you can comment on or make changes to this bug.