Bug 159041

Summary:

Move WebKit2 Apple Pay code to the open source repository

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mkwst

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	sam: review+

Description Anders Carlsson 2016-06-22 14:45:28 PDT

Move WebKit2 Apple Pay code to the open source repository

Comment 1 Anders Carlsson 2016-06-24 09:19:26 PDT

Created attachment 281983 [details]
Patch

Comment 2 WebKit Commit Bot 2016-06-24 09:21:47 PDT

Attachment 281983 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:101:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:180:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:181:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:182:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:216:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:254:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:395:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:253:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:269:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:285:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:301:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp:79:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:42:  The parameter name "paymentRequest" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:56:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:58:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:113:  The parameter name "preferencesRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:114:  The parameter name "preferencesRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:116:  The parameter name "preferencesRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:117:  The parameter name "preferencesRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:120:  The parameter name "preferencesRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:121:  The parameter name "preferencesRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:58:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:64:  The parameter name "status" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:85:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:46:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:95:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:96:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:129:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:144:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 37 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Alex Christensen 2016-06-24 09:34:08 PDT

Comment on attachment 281983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281983&action=review

> Source/WebKit2/Shared/Cocoa/ArgumentCodersCocoa.mm:33
> +    +    auto data = adoptNS([[NSMutableData alloc] init]);

I don't think these +es should be here.

Comment 4 Anders Carlsson 2016-06-24 09:35:13 PDT

(In reply to comment #3)
> Comment on attachment 281983 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281983&action=review
> 
> > Source/WebKit2/Shared/Cocoa/ArgumentCodersCocoa.mm:33
> > +    +    auto data = adoptNS([[NSMutableData alloc] init]);
> 
> I don't think these +es should be here.

You're right, I've removed that file altogether.

Comment 5 Anders Carlsson 2016-06-24 09:39:38 PDT

Created attachment 281986 [details]
Patch

Comment 6 WebKit Commit Bot 2016-06-24 09:41:22 PDT

Attachment 281986 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:101:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:214:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp:79:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:52:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:55:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:56:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:57:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:58:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:113:  The parameter name "preferencesRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:114:  The parameter name "preferencesRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:116:  The parameter name "preferencesRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:117:  The parameter name "preferencesRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:120:  The parameter name "preferencesRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:121:  The parameter name "preferencesRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:58:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h:85:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:46:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:95:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:96:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:129:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:144:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 22 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Anders Carlsson 2016-06-24 11:31:20 PDT

Committed r202432: <http://trac.webkit.org/changeset/202432>