Bug 159034

Summary: [jhbuild] Added libxslt module.
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, lforschler, mcatanzaro, ossy
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-06-22 12:36:56 PDT
libxslt depends on libxml2 so it's not acceptable to use system librarywhen libxml2 is provided by jhbuild. Also deduplicated libxml2 module between GTK and EFL.
Attachments
Patch (4.08 KB, patch)
2016-06-22 12:38 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (5.33 KB, patch)
2016-06-22 12:43 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (2.69 KB, patch)
2016-06-22 14:39 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-06-22 12:38:29 PDT
Created attachment 281861 [details] Patch
Konstantin Tokarev
Comment 2 2016-06-22 12:43:36 PDT
Created attachment 281863 [details] Patch
Michael Catanzaro
Comment 3 2016-06-22 13:49:25 PDT
Comment on attachment 281863 [details] Patch We want the modulesets to be completely separate so we can change our versions without affecting EFL and vice versa, so that nobody has to rebaseline another port's layout tests!
Konstantin Tokarev
Comment 4 2016-06-22 14:39:52 PDT
Created attachment 281871 [details] Patch
Michael Catanzaro
Comment 5 2016-06-22 18:50:22 PDT
Comment on attachment 281871 [details] Patch Be sure to remove it from Tools/[eft/gtk]/install-dependencies as well.
WebKit Commit Bot
Comment 6 2016-06-23 02:52:03 PDT
Comment on attachment 281871 [details] Patch Clearing flags on attachment: 281871 Committed r202373: <http://trac.webkit.org/changeset/202373>
WebKit Commit Bot
Comment 7 2016-06-23 02:52:07 PDT
All reviewed patches have been landed. Closing bug.
Konstantin Tokarev
Comment 8 2016-06-23 12:24:48 PDT
Committed r202392: <http://trac.webkit.org/changeset/202392>
Gyuyoung Kim
Comment 9 2016-06-23 21:55:19 PDT
Unfortunately we can't access ftp://xmlsoft.org/source/ directory in Korea. So we need to change the download path. I did it -http://trac.webkit.org/changeset/202416 Additionally EFL port doesn't support {version} variable. I will support it in near future.
Csaba Osztrogonác
Comment 10 2016-10-20 09:44:38 PDT
(In reply to comment #9) > Additionally EFL port doesn't support {version} variable. I will support it > in near future. How is it possible? Tools/jhbuild/jhbuild-wrapper guarantees that all ports use the exactly same jhbuild version.
Note You need to log in before you can comment on or make changes to this bug.