Bug 159005

Summary: Move the last Apple Pay WebCore files to the open source repository
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, kondapallykalyan, mkwst
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Anders Carlsson
Reported 2016-06-21 17:25:13 PDT
Move the last Apple Pay WebCore files to the open source repository
Attachments
Patch (216.44 KB, patch)
2016-06-21 17:33 PDT, Anders Carlsson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-06-21 17:33:28 PDT
Created attachment 281798 [details] Patch
WebKit Commit Bot
Comment 2 2016-06-21 17:34:56 PDT
Attachment 281798 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:55: STATUS_SUCCESS is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:56: STATUS_FAILURE is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:57: STATUS_INVALID_BILLING_POSTAL_ADDRESS is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:58: STATUS_INVALID_SHIPPING_POSTAL_ADDRESS is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:59: STATUS_INVALID_SHIPPING_CONTACT is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:60: STATUS_PIN_REQUIRED is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:61: STATUS_PIN_INCORRECT is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:62: STATUS_PIN_LOCKOUT is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:130: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:136: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 10 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2016-06-21 18:04:03 PDT
Comment on attachment 281798 [details] Patch rs=me
Anders Carlsson
Comment 4 2016-06-21 18:05:44 PDT
Committed r202309: <http://trac.webkit.org/changeset/202309>
Note You need to log in before you can comment on or make changes to this bug.