Bug 158999

Summary: Options::useImmortalObjects is not safe for conservative GC
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Geoffrey Garen
Reported 2016-06-21 14:52:00 PDT
Options::useImmortalObjects is not safe for conservative GC
Attachments
Patch (5.56 KB, patch)
2016-06-21 15:07 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (5.30 KB, patch)
2016-06-21 15:19 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.46 KB, patch)
2016-06-21 15:32 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.47 KB, patch)
2016-06-21 15:33 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2016-06-21 15:07:29 PDT
Created attachment 281784 [details] Patch
Michael Saboff
Comment 2 2016-06-21 15:09:12 PDT
Comment on attachment 281784 [details] Patch r=me
Joseph Pecoraro
Comment 3 2016-06-21 15:14:35 PDT
Comment on attachment 281784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281784&action=review > Source/JavaScriptCore/heap/Heap.cpp:-1476 > - if (Options::useImmortalObjects()) > - markDeadObjects(); This is the only use of Options::useImmortalObjects. Should we remove the Option, or should we leave in legacy options even if they do nothing?
Joseph Pecoraro
Comment 4 2016-06-21 15:14:56 PDT
Comment on attachment 281784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281784&action=review > Source/JavaScriptCore/heap/MarkedAllocator.cpp:74 > + bool isImmortal = block->state() != MarkedBlock::New && Options::useImmortalObjects(); I see it is now used here! Nevermind =)
Geoffrey Garen
Comment 5 2016-06-21 15:19:55 PDT
Created attachment 281786 [details] Patch
Michael Saboff
Comment 6 2016-06-21 15:21:04 PDT
Comment on attachment 281786 [details] Patch LGTM
Mark Lam
Comment 7 2016-06-21 15:25:40 PDT
Comment on attachment 281786 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281786&action=review > Source/JavaScriptCore/heap/MarkedAllocator.cpp:225 > + if (Options::useImmortalObjects()) { Make this UNLIKELY(Options::useImmortalObjects())?
Geoffrey Garen
Comment 8 2016-06-21 15:32:29 PDT
Created attachment 281788 [details] Patch for landing
Geoffrey Garen
Comment 9 2016-06-21 15:33:51 PDT
Created attachment 281789 [details] Patch for landing
WebKit Commit Bot
Comment 10 2016-06-21 16:06:18 PDT
Comment on attachment 281789 [details] Patch for landing Clearing flags on attachment: 281789 Committed r202299: <http://trac.webkit.org/changeset/202299>
WebKit Commit Bot
Comment 11 2016-06-21 16:06:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.