Summary: | [Win] Implement modal dialog support in MiniBrowser. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||
Component: | Tools / Tests | Assignee: | Per Arne Vollan <pvollan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, lforschler | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Per Arne Vollan
2016-06-20 23:27:51 PDT
Created attachment 281718 [details]
Patch
Created attachment 281720 [details]
Patch
Comment on attachment 281720 [details] Patch Attachment 281720 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1540496 New failing tests: fast/scrolling/ios/scrollTo-at-page-load.html Created attachment 281723 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Comment on attachment 281720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281720&action=review Cool! r=me. > Tools/MiniBrowser/win/PrintWebUIDelegate.cpp:30 > +#include <CoreFoundation/CoreFoundation.h> Should this be wrapped in a #if USE(CF) ? Note: The iOS test failure cannot possibly be related to these Windows-specific Minibrowser changes. Please disregard the EWS error. Thanks for reviewing :) Committed r202327: <https://trac.webkit.org/changeset/202327> |