Bug 158976

Summary: [Win] Implement modal dialog support in MiniBrowser.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+, buildbot: commit-queue-
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Per Arne Vollan
Reported 2016-06-20 23:27:51 PDT
MiniBrowser does not show modal dialogs on Windows.
Attachments
Patch (8.66 KB, patch)
2016-06-20 23:37 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (8.76 KB, patch)
2016-06-20 23:57 PDT, Per Arne Vollan 		bfulgham: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (621.89 KB, application/zip)
2016-06-21 01:00 PDT, Build Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2016-06-20 23:37:45 PDT
Created attachment 281718 [details] Patch
Per Arne Vollan
Comment 2 2016-06-20 23:57:09 PDT
Created attachment 281720 [details] Patch
Build Bot
Comment 3 2016-06-21 01:00:49 PDT
Comment on attachment 281720 [details] Patch Attachment 281720 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1540496 New failing tests: fast/scrolling/ios/scrollTo-at-page-load.html
Build Bot
Comment 4 2016-06-21 01:00:50 PDT
Created attachment 281723 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Brent Fulgham
Comment 5 2016-06-21 11:28:19 PDT
Comment on attachment 281720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281720&action=review Cool! r=me. > Tools/MiniBrowser/win/PrintWebUIDelegate.cpp:30 > +#include <CoreFoundation/CoreFoundation.h> Should this be wrapped in a #if USE(CF) ?
Brent Fulgham
Comment 6 2016-06-21 11:29:11 PDT
Note: The iOS test failure cannot possibly be related to these Windows-specific Minibrowser changes. Please disregard the EWS error.
Per Arne Vollan
Comment 7 2016-06-22 01:37:41 PDT
Thanks for reviewing :)
Per Arne Vollan
Comment 8 2016-06-22 01:38:20 PDT
Committed r202327: <https://trac.webkit.org/changeset/202327>
Note You need to log in before you can comment on or make changes to this bug.