Bug 158976

Summary: [Win] Implement modal dialog support in MiniBrowser.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Tools / TestsAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+, buildbot: commit-queue-
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Description Per Arne Vollan 2016-06-20 23:27:51 PDT
MiniBrowser does not show modal dialogs on Windows.
Comment 1 Per Arne Vollan 2016-06-20 23:37:45 PDT
Created attachment 281718 [details]
Patch
Comment 2 Per Arne Vollan 2016-06-20 23:57:09 PDT
Created attachment 281720 [details]
Patch
Comment 3 Build Bot 2016-06-21 01:00:49 PDT
Comment on attachment 281720 [details]
Patch

Attachment 281720 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1540496

New failing tests:
fast/scrolling/ios/scrollTo-at-page-load.html
Comment 4 Build Bot 2016-06-21 01:00:50 PDT
Created attachment 281723 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 5 Brent Fulgham 2016-06-21 11:28:19 PDT
Comment on attachment 281720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281720&action=review

Cool! r=me.

> Tools/MiniBrowser/win/PrintWebUIDelegate.cpp:30
> +#include <CoreFoundation/CoreFoundation.h>

Should this be wrapped in a #if USE(CF) ?
Comment 6 Brent Fulgham 2016-06-21 11:29:11 PDT
Note: The iOS test failure cannot possibly be related to these Windows-specific Minibrowser changes. Please disregard the EWS error.
Comment 7 Per Arne Vollan 2016-06-22 01:37:41 PDT
Thanks for reviewing :)
Comment 8 Per Arne Vollan 2016-06-22 01:38:20 PDT
Committed r202327: <https://trac.webkit.org/changeset/202327>