Bug 158931

Summary: WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, beidson, commit-queue, ddkilzer, lforschler, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2016-06-19 23:31:31 PDT
In Tools/WebKitTestRunner/TestInvocation.cpp, > #if PLATFORM(COCOA) > pid_t pid = WKPageGetProcessIdentifier(TestController::singleton().mainWebView()->page()); > sprintf(errorMessageToStderr, "#PROCESS UNRESPONSIVE - %s (pid %ld)\n", TestController::webProcessName(), static_cast<long>(pid)); > #else > sprintf(errorMessageToStderr, "#PROCESS UNRESPONSIVE - %s", TestController::webProcessName()); > #endif \n is missing in the second sprintf.
Attachments
Patch (1.56 KB, patch)
2016-06-19 23:35 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2016-06-19 23:35:36 PDT
Created attachment 281634 [details] Patch
WebKit Commit Bot
Comment 2 2016-06-20 00:07:14 PDT
Comment on attachment 281634 [details] Patch Clearing flags on attachment: 281634 Committed r202226: <http://trac.webkit.org/changeset/202226>
WebKit Commit Bot
Comment 3 2016-06-20 00:07:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.