Summary: | URL hash setter does not remove fragment identifier if argument is an empty string | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robert Knight <robertknight> | ||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, darin, esprehn+autocc, gyuyoung.kim, rniwa, sam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Safari 9 | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Robert Knight
2016-06-17 04:59:27 PDT
Created attachment 281569 [details]
Patch
Comment on attachment 281569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281569&action=review > Source/WebCore/html/URLUtils.h:287 > + String newFragment = value[0U] == '#' ? value.substring(1) : value; Would be better if some day setFragmentIdentifier was changed to take a StringView, then we would not have to allocate a new string just to contain a substring of what we were passed. Comment on attachment 281569 [details] Patch Clearing flags on attachment: 281569 Committed r202176: <http://trac.webkit.org/changeset/202176> All reviewed patches have been landed. Closing bug. @Robert Knight: You should be able to test/verify the fix using tomorrow's nightly build at https://webkit.org/nightly/ Wow! That's a fast turn around. Thank-you both! |