Bug 158860 – Support configurable autocapitalization

• Component: WebKit2
• Status: RESOLVED FIXED

[Enrica Casucci]

rdar://problem/26231403

[Enrica Casucci]

Created attachment 281514 [details]
Patch

[WebKit Commit Bot]

Attachment 281514 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:309:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:451:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Enrica Casucci]

Created attachment 281515 [details]
Patch2

Fixes GTK and EFL builds.

[WebKit Commit Bot]

Attachment 281515 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:309:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:451:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 281515 [details]
Patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=281515&action=review

Please fix the iOS build before landing. Also, have you tested this on iOS?

> Source/WebKit2/UIProcess/API/C/WKPageConfigurationRef.cpp:107
> +void WKPageConfigurationSetIntialCapitalizationEnabled(WKPageConfigurationRef configuration, bool enabled)

Intial should read "Initial"

> Source/WebKit2/UIProcess/API/C/WKPageConfigurationRef.h:57
> +WK_EXPORT void WKPageConfigurationSetIntialCapitalizationEnabled(WKPageConfigurationRef configuration, bool enabled);

Intial should read "Initial"

> Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:51
> +// FIXME: this needs to be removed and NSTextCheckingSuppressInitialCapitalizationKey as soon as

Something weird about the grammar here.

> Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:309
> +    options = @{ NSTextCheckingInsertionPointKey :  [NSNumber numberWithUnsignedInteger:insertionPoint],
> +                 WebTextCheckingSuppressInitialCapitalizationKey : [NSNumber numberWithBool:!initialCapitalizationEnabled] };

If we're using @{}, we should be able to use @() instead of numberWithBlah: here, like so:

options = @{ NSTextCheckingInsertionPointKey : @(insertionPoint),
             WebTextCheckingSuppressInitialCapitalizationKey : @(!initialCapitalizationEnabled) };

> Source/WebKit2/UIProcess/mac/TextCheckerMac.mm:450
> +    options = @{ NSTextCheckingInsertionPointKey :  [NSNumber numberWithUnsignedInteger:insertionPoint],

Ditto.

[Enrica Casucci]

Committed revision 202185.

[Enrica Casucci]

This should be done when we use advance spelling and when we don't.

[Enrica Casucci]

Created attachment 284551 [details]
Patch

[Enrica Casucci]

Committed revision 203724.