Bug 158825

Summary:

Move SoftLinking.h to platform/cococa from platform/mac

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	none

Description David Kilzer (:ddkilzer) 2016-06-15 19:48:40 PDT

Move SoftLinking.h to platform/cococa from platform/mac because it's used on both iOS and macOS.

Comment 1 David Kilzer (:ddkilzer) 2016-06-15 19:52:18 PDT

Created attachment 281429 [details]
Patch v1

Comment 2 WebKit Commit Bot 2016-06-15 19:54:08 PDT

Attachment 281429 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:28:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:110:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:128:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:133:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:434:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:447:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:452:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:464:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:475:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/cocoa/SoftLinking.h:480:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 11 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 WebKit Commit Bot 2016-06-15 20:22:07 PDT

Comment on attachment 281429 [details]
Patch v1

Clearing flags on attachment: 281429

Committed r202122: <http://trac.webkit.org/changeset/202122>

Comment 4 WebKit Commit Bot 2016-06-15 20:22:10 PDT

All reviewed patches have been landed.  Closing bug.