Bug 158808

Summary: Uncaught Exception: TypeError: undefined is not an object (evaluating 'imageElement.classList')
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
URL: http://www.apple.com/watch/
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2016-06-15 13:36:52 PDT 
I see this occasionally.

-------
Auto-generated details:

Inspected URL:        http://www.apple.com/watch/
Uncaught exceptions:
 - TypeError: undefined is not an object (evaluating 'imageElement.classList') (at HeapAllocationsTimelineOverviewGraph.js:112:21)
    _updateSnapshotMarkers @ HeapAllocationsTimelineOverviewGraph.js:112:21
    updateSelectedRecord @ HeapAllocationsTimelineOverviewGraph.js:95:36
    ? @ TimelineOverviewGraph.js:248:38
-------

* STEPS TO REPRODUCE
1. Inspect apple.com/watch/
2. Start a timeline recording and stop
3. Add Allocations timeline
4. Wait 10 seconds so a new recording would be offscreen of the overview graph
5. Take a heap snapshot
6. Go into that heap snapshot
  => Exception

* NOTES
I think the issue here is that the snapshot doesn't have an image element in the overview graph, so we should have bailed earlier.
Comment 1 Radar WebKit Bug Importer 2016-06-15 13:38:54 PDT 
<rdar://problem/26821034>
Comment 2 Joseph Pecoraro 2016-06-15 13:42:35 PDT 
Created attachment 281385 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2016-06-15 13:54:42 PDT 
Comment on attachment 281385 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2016-06-15 14:15:12 PDT 
Comment on attachment 281385 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 281385

Committed r202106: <http://trac.webkit.org/changeset/202106>
Comment 5 WebKit Commit Bot 2016-06-15 14:15:16 PDT 
All reviewed patches have been landed.  Closing bug.