Summary: | OOM Assertion failure in Array.prototype.toString | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | André Bargull <andre.bargull> | ||||
Component: | JavaScriptCore | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, keith_miller, mark.lam, msaboff, ossy, saam | ||||
Priority: | P2 | ||||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=171630 | ||||||
Bug Depends on: | 159807 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
André Bargull
2016-06-15 10:23:29 PDT
Created attachment 281956 [details]
Patch
Comment on attachment 281956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281956&action=review r=me > LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js:3 > +// Based on André Bargull's test case. weird characters here? > LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js:3 > +// Based on André Bargull's test case. ditto Comment on attachment 281956 [details] Patch > > LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js:3 > > +// Based on André Bargull's test case. > > weird characters here? > > > LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js:3 > > +// Based on André Bargull's test case. > > ditto That's just bugzilla. It never does well with UTF8. Comment on attachment 281956 [details] Patch Clearing flags on attachment: 281956 Committed r202415: <http://trac.webkit.org/changeset/202415> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > Comment on attachment 281956 [details] > Patch > > Clearing flags on attachment: 281956 > > Committed r202415: <http://trac.webkit.org/changeset/202415> These new tests consume huge memory, my PC with 8Gb memory started to swap and became unresponsible for long time when I exectuted run-javascriptcore-tests. :( It would be good not adding tests need 16-32-64Gb memory to be able to run. :( |