Bug 158717

Summary:

[Cocoa] Avoid extra copy of headers dictionary in ResourceResponse::platformLazyInit()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, commit-queue, darin

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2016-06-13 18:49:23 PDT

Avoid extra copy of headers dictionary in ResourceResponse::platformLazyInit() by calling CFHTTPMessageCopyAllHeaderFields() instead of [NSURLResponse allHeaderFields].

Attachments
Patch (3.96 KB, patch) 2016-06-13 18:52 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2016-06-13 18:49:29 PDT

rdar://problem/26778863

Chris Dumez

Comment 2 2016-06-13 18:52:07 PDT

Created attachment 281224 [details] Patch

Alex Christensen

Comment 3 2016-06-14 00:07:31 PDT

Comment on attachment 281224 [details] Patch Woohoo!!! Fewer copies!!! R=me allHeaderFields is marked in the public API with @property (readonly, copy) NSDictionary *allHeaderFields;

WebKit Commit Bot

Comment 4 2016-06-14 07:29:49 PDT

Comment on attachment 281224 [details] Patch Clearing flags on attachment: 281224 Committed r202042: <http://trac.webkit.org/changeset/202042>

WebKit Commit Bot

Comment 5 2016-06-14 07:29:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.